Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_primitive_cell from spglib #433

Merged
merged 5 commits into from
Nov 24, 2021
Merged

add get_primitive_cell from spglib #433

merged 5 commits into from
Nov 24, 2021

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Nov 22, 2021

This function returns the primitive cell of the current structure, i.e. if a primitive cell is repeated, the cell before repetition will be returned.

@samwaseda samwaseda marked this pull request as draft November 22, 2021 17:48
@coveralls
Copy link

coveralls commented Nov 22, 2021

Pull Request Test Coverage Report for Build 1496913398

  • 18 of 19 (94.74%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/symmetry.py 18 19 94.74%
Totals Coverage Status
Change from base Build 1478814279: 0.03%
Covered Lines: 11440
Relevant Lines: 16388

💛 - Coveralls

@samwaseda samwaseda marked this pull request as ready for review November 22, 2021 19:54
@samwaseda samwaseda merged commit 14439e7 into master Nov 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the get_primitive_cell branch November 24, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants