Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertion test to symmetry permutation #463

Merged
merged 7 commits into from
Dec 10, 2021
Merged

Conversation

samwaseda
Copy link
Member

@samwaseda samwaseda commented Dec 8, 2021

And I just realised that the algorithm doesn't always work. Here I add a simple assertion test in order to be able to fail properly when this happens.

In order not to repeat the mistake, I keep this one open for 24h.

@coveralls
Copy link

coveralls commented Dec 8, 2021

Pull Request Test Coverage Report for Build 1560820691

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 69.956%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/symmetry.py 13 14 92.86%
Totals Coverage Status
Change from base Build 1555113194: 0.01%
Covered Lines: 11521
Relevant Lines: 16469

💛 - Coveralls

@samwaseda samwaseda merged commit 9fb077b into master Dec 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the sym_permutations branch December 10, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants