Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename unit test workflow #572

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Rename unit test workflow #572

merged 1 commit into from
Mar 25, 2022

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Mar 24, 2022

I found it annoying that the workflow for unit tests is labeled "Python Package", so I changed it.

@pmrv pmrv requested a review from niklassiemer March 24, 2022 09:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2033357485

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.726%
Totals Coverage Status
Change from base Build 2020914336: 0.0%
Covered Lines: 11901
Relevant Lines: 16827
💛 - Coveralls

jan-janssen
jan-janssen approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but maybe also update the other pyiron packages

@pmrv pmrv merged commit 78735ef into master Mar 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the pmrv-patch-1 branch March 25, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@niklassiemer niklassiemer Awaiting requested review from niklassiemer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmrv @coveralls @jan-janssen