-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executable: Switch from HasHDF to HasDict #1377
Conversation
…_dict # Conflicts: # pyiron_base/jobs/job/extension/executable.py
Actually wouldn't it be much easier to just give def to_dict(self):
return self.storage.to_builtin()
def from_dict(self, data_dict):
self.storage.clear()
self.storage.update(data_dict) |
@@ -40,6 +43,7 @@ def __init__( | |||
overwrite_nt_flag (bool): | |||
""" | |||
super().__init__() | |||
self.storage = DataContainer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmrv We still use the DataContainer
here
Co-authored-by: Marvin Poul <poul@mpie.de>
@@ -1049,6 +1050,9 @@ def to_dict(self): | |||
"exclude_groups_hdf": self._exclude_groups_hdf, | |||
} | |||
data_dict["server"] = self._server.to_dict() | |||
self._executable_activate_mpi() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmrv The self._executable_activate_mpi()
was just moved up the to the point where the to_dict()
method is called on the executable
object.
As I commented in #1398 I do not think it is that easy but I am happy if you convince me otherwise. |
This pull request reverts parts of #728 to simplify the
to_dict()
andfrom_dict()
interface of theGenericJob
class. In the future the interface should use__getstate__()
and__setstate__()
.