Executable: Switch from HasHDF to HasDict #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_dict # Conflicts: # pyiron_base/jobs/job/extension/executable.py
jan-janssen
added
format_black
jan-janssen
changed the title
pmrv
reviewed
Mar 26, 2024
pmrv
reviewed
Mar 26, 2024
pmrv
reviewed
Mar 26, 2024
pmrv
reviewed
Mar 26, 2024
|
Actually wouldn't it be much easier to just give def to_dict(self):
return self.storage.to_builtin()
def from_dict(self, data_dict):
self.storage.clear()
self.storage.update(data_dict) |
jan-janssen
commented
Mar 26, 2024
| @@ -40,6 +43,7 @@ def __init__( | |||
| overwrite_nt_flag (bool): | |||
| """ | |||
| super().__init__() | |||
| self.storage = DataContainer() | |||
There was a problem hiding this comment.
@pmrv We still use the DataContainer here
Co-authored-by: Marvin Poul <poul@mpie.de>
jan-janssen
commented
Mar 26, 2024
| @@ -1049,6 +1050,9 @@ def to_dict(self): | |||
| "exclude_groups_hdf": self._exclude_groups_hdf, | |||
| } | |||
| data_dict["server"] = self._server.to_dict() | |||
| self._executable_activate_mpi() | |||
There was a problem hiding this comment.
@pmrv The self._executable_activate_mpi() was just moved up the to the point where the to_dict() method is called on the executable object.
As I commented in #1398 I do not think it is that easy but I am happy if you convince me otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts parts of #728 to simplify the
to_dict()andfrom_dict()interface of theGenericJobclass. In the future the interface should use__getstate__()and__setstate__().