[patch] use deprecate from pyiron_snippets #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan-janssen I left it with the backwards compatibility you found confusing -- I'll stack an additional PR on top doing a [minor] bump that removes the compatibility and clarifies the situation |
i.e. pyiron_base.state.logger.logger with pyiron_snippets.logger.logger. The original location leaves a re-direct for backwards compatibility.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
[minor] remove the backwards compatibility redirects
jan-janssen
reviewed
Jun 3, 2024
pyiron_base/__init__.py
Outdated
| @@ -47,6 +46,7 @@ | |||
|
|
|||
| # Expose snippets references in base API for backwards compatibility | |||
| from pyiron_snippets.import_alarm import ImportAlarm | |||
| from pyiron_snippets.deprecate import Deprecator, deprecate, deprecate_soon | |||
There was a problem hiding this comment.
Suggested change
| from pyiron_snippets.deprecate import Deprecator, deprecate, deprecate_soon |
[patch] replace logger with snippets version
|
@jan-janssen going forward I recommend merging stacks from the bottom up instead of the top down -- now this PR is big and it's not immediately clear to me where all the problems are coming from. Diff markup got committed directly though, so that's definitely part of it. |
…_deprecate # Conflicts: # pyiron_base/utils/error.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.