Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scriptjob implement calculate() function #1480

Merged
merged 25 commits into from
Jun 20, 2024
Merged

Scriptjob implement calculate() function #1480

merged 25 commits into from
Jun 20, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 12, 2024 •
edited
Loading

Implement calculate() function for ScriptJob:

calculate_function = job.generate_calculate_function()
kwargs = job.generate_calculate_function_kwargs()
shell_output, parsed_output, job_crashed = calculate_function(**kwargs)

@jan-janssen jan-janssen marked this pull request as draft June 12, 2024 11:43
This was referenced Jun 12, 2024
Merged
Merged
Base automatically changed from scriptjob_get_input_file_dict to main June 17, 2024 19:50
@jan-janssen jan-janssen changed the base branch from main to executablecontainer_runstatic June 17, 2024 19:50
@jan-janssen jan-janssen marked this pull request as ready for review June 17, 2024 20:03
@jan-janssen
Copy link
Member Author

@samwaseda Can you take a look at this pull request? I would like to merge it before releasing the new pyiron_base version.

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Jun 20, 2024
@jan-janssen jan-janssen merged commit df85bc1 into executablecontainer_runstatic Jun 20, 2024
23 checks passed
@jan-janssen jan-janssen deleted the scriptjob_calculate branch June 20, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
format_black reformat the code using the black standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jan-janssen @pyiron-runner