Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptJob: Replace write_input() with get_input_file_dict() #1479

Merged
merged 4 commits into from
Jun 17, 2024
Merged

ScriptJob: Replace write_input() with get_input_file_dict() #1479

merged 4 commits into from
Jun 17, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 12, 2024 •
edited
Loading

Using the write_input() function implemented in GenericJob #1472 also for the ScriptJob class. So in the ScriptJob class we only need to implement the get_input_file_dict() function. This is again in preparation for #1480

@jan-janssen jan-janssen mentioned this pull request Jun 12, 2024
Merged
@jan-janssen jan-janssen merged commit 8f35a69 into main Jun 17, 2024
25 checks passed
@jan-janssen jan-janssen deleted the scriptjob_get_input_file_dict branch June 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jan-janssen