Always write input files #1574
Merged
Always write input files #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check always fails for submitted jobs
samwaseda
reviewed
Jul 31, 2024
|
We added this to fix the remote jobs, so we have to be careful we do not break those. #1511 |
|
I did also observe that VASP jobs still work somehow similar to that you wrote in the linked issue. I'm guessing that somewhere vasp still writes the input files outside of the calculate function control flow. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check always fails for submitted jobs and currently prevents lammps jobs to be submitted to the queue. For some reason vasp jobs still work, but I'll leave that for someone else to figure out.