-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for type conservation #508
Conversation
tests/generic/test_fileHDFio.py
Outdated
all( | ||
np.equal( | ||
content_dict["key_2"], | ||
np.array([1, 2, 3, 4, 5, 6]), | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all( | |
np.equal( | |
content_dict["key_2"], | |
np.array([1, 2, 3, 4, 5, 6]), | |
) | |
) | |
np.array_equal( | |
content_dict["key_2"], | |
np.array([1, 2, 3, 4, 5, 6]), | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That pattern comes up a few times, but array_equal
should be correct for all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except for the array_equal
nit.
tests/generic/test_fileHDFio.py
Outdated
all( | ||
np.equal( | ||
content_dict["key_2"], | ||
np.array([1, 2, 3, 4, 5, 6]), | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That pattern comes up a few times, but array_equal
should be correct for all of them.
Co-authored-by: Marvin Poul <poul@mpie.de>
This should cause pyiron/pyiron_atomistics#409 to pop up on our
pyiron_base
unittests already instead of in the compatibility withpyiron_atomistics
integration tests.