Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy files on restart #511

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Do not copy files on restart #511

merged 6 commits into from
Nov 15, 2021

Conversation

sudarsan-surendralal
Copy link
Member

See linked issue

@pmrv
Copy link
Contributor

pmrv commented Nov 11, 2021

We still want to copy certain files, though, like CONTCAR, right? Is that taken care of separately?

@sudarsan-surendralal
Copy link
Member Author

We still want to copy certain files, though, like CONTCAR, right? Is that taken care of separately?

Yes, for that we need to use restart_file_list and/or restart_file_dict.

@sudarsan-surendralal sudarsan-surendralal added the code_smell It's working, but something smells off label Nov 11, 2021
pyiron_base/_tests.py Outdated Show resolved Hide resolved
@jan-janssen
Copy link
Member

Just for me to understand this correctly, this behavior was introduced in #349 right?

@sudarsan-surendralal
Copy link
Member Author

Just for me to understand this correctly, this behavior was introduced in #349 right?

Yes and it worked well. But I guess having the new parameter copy_files with True as the default meant that the restart function which called this automatically copied all files (once again emphasizing the need for more tests on pyiron_base).

@sudarsan-surendralal sudarsan-surendralal marked this pull request as draft November 12, 2021 09:24
@sudarsan-surendralal
Copy link
Member Author

sudarsan-surendralal commented Nov 12, 2021

It seems that the output also seems to be copied during the restart. So I'm converting this to draft till I figure out what's going on.

Edit: False alarm, everything seems okay! Do let me know if any further changes are required @jan-janssen @pmrv

@sudarsan-surendralal sudarsan-surendralal marked this pull request as ready for review November 12, 2021 16:35
@sudarsan-surendralal sudarsan-surendralal merged commit 4f50b8d into master Nov 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the restart_fixes branch November 15, 2021 19:25
@sudarsan-surendralal
Copy link
Member Author

@niklassiemer @muh-hassani Can you make a new release with these changes (also for the cluster)?

@niklassiemer
Copy link
Member

Sure, we will trigger a new release with minor (not only patch level) version bump once we fixed the current problems with the hdf and db connection bugs we have in our master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code_smell It's working, but something smells off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressed files are copied when restarting jobs
4 participants