Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodeJob compliant with the storage interface #209

Merged
merged 13 commits into from
Feb 17, 2024

Conversation

liamhuber
Copy link
Member

What happened is that I merged the NodeJob branch into its parent storage branch before making sure the NodeJob branch had pulled in its most-up-to-date parent. I didn't notice the incompatibility because the CI was broken due to missing dependencies. Obviously with broken CI I should have been more careful, but also this is sort of a chance I took when I chose to merge anything to anywhere else when the CI was not passing.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/patch_jobs_in_storage

Copy link

codacy-production bot commented Feb 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 648cfdc1 78.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (648cfdc) Report Missing Report Missing Report Missing
Head commit (3f0f8d9) 3061 2655 86.74%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#209) 14 11 78.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Feb 17, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@liamhuber liamhuber merged commit 2a887dc into simple_storage Feb 17, 2024
12 of 13 checks passed
@liamhuber liamhuber deleted the patch_jobs_in_storage branch February 17, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants