-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NodeJob compliant with the storage interface #209
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation Footnotes
|
It was just not showing up because the test name was doubled up
And test for it, hopefully, we'll find out on the CI I guess
Otherwise we check to see if storage is there and get an error
…h_jobs_in_storage
Out of kindness
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
What happened is that I merged the
NodeJob
branch into its parentstorage
branch before making sure theNodeJob
branch had pulled in its most-up-to-date parent. I didn't notice the incompatibility because the CI was broken due to missing dependencies. Obviously with broken CI I should have been more careful, but also this is sort of a chance I took when I chose to merge anything to anywhere else when the CI was not passing.