Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NodeJob compliant with the storage interface #209

Merged
merged 13 commits into from
Feb 17, 2024
Merged

Make NodeJob compliant with the storage interface #209

merged 13 commits into from
Feb 17, 2024

Commits on Feb 16, 2024

  1. Make NodeJob compliant with the storage interface

    @liamhuber
    liamhuber committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0370f52 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Wrap tests that use storage in a version check

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    84c326c View commit details
    Browse the repository at this point in the history

  2. 🐛 de-double and de-bug the node test 

    It was just not showing up because the test name was doubled up
    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    f831420 View commit details
    Browse the repository at this point in the history

  3. Fail hard and clean when the python version is too low 

    And test for it, hopefully, we'll find out on the CI I guess
    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    6abc23a View commit details
    Browse the repository at this point in the history

  4. Don't even try loading if python <3.11 

    Otherwise we check to see if storage is there and get an error
    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    740e236 View commit details
    Browse the repository at this point in the history

  5. 🐛 Add missed skipIf

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    8fbd070 View commit details
    Browse the repository at this point in the history

  6. Add a warning to the node job tests

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    dc1ea55 View commit details
    Browse the repository at this point in the history

  7. Only test node job docs on valid python versions

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    e03ab93 View commit details
    Browse the repository at this point in the history

  8. Add the version requirement right to the top of the docs about storage

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    afc7d90 View commit details
    Browse the repository at this point in the history

  9. Add the version requirement right to the top of the docs about storage

    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    c7474f3 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/patch_jobs_in_storage' into patc… 

    …h_jobs_in_storage
    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    d21e85a View commit details
    Browse the repository at this point in the history

  11. Add version filtering to the deepdive 

    Out of kindness
    @liamhuber
    liamhuber committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    fabf465 View commit details
    Browse the repository at this point in the history

  12. Format black

    @pyiron-runner
    pyiron-runner committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    3f0f8d9 View commit details
    Browse the repository at this point in the history