-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper datetime module implementation #326
Comments
From luke.lei...@gmail.com on April 25, 2010 12:21:07: |
From luke.lei...@gmail.com on April 25, 2010 12:22:00: |
From luke.lei...@gmail.com on April 25, 2010 12:25:26: diff --git a/examples/libtest/StringTest.py b/examples/libtest/StringTest.py
|
From luke.lei...@gmail.com on April 25, 2010 12:27:02: whoops :) that's under standard python2.5 - probably because i haven't got GMT |
From a.mottola@gmail.com on April 25, 2010 13:34:11: I'm attaching a diff providing correct copyright informations (thanks for putting my I was aware of one test failing in the unit test: it seems I forgot to mention it, |
From cornelis...@gmail.com on May 20, 2010 09:16:00: I added a separate script to test the time module at different timezones (with pyv8). I can't guarantee I've got all the bugs (should run the tests at different clock To run the test in different time zones:
|
From cornelis...@gmail.com on May 20, 2010 09:23:06: |
From cornelis...@gmail.com on May 20, 2010 09:40:24: See r2440 |
From cornelis...@gmail.com on May 20, 2010 11:52:51: The datetime.fromordinal() and datetime.toordinal() also need to be fixed. Could you |
Have all the patches been added to the master branch as of today? |
Hello,
I noticed the existing datetime module in pyjs only contains a non-standard
"Datetime" class, which acts as a thin layer above the JS Date class.
In order to comply with the Python standard library, I rewrote the module
to a proper implementation, including datetime.date, datetime.time,
datetime.datetime and datetime.timedelta classes.
Attached is the diff to the old datetime.py source, and an additional unit
test for LibTest to properly test the new implementation.
The patch removes the old "Datetime" class; it was only used once in the
Gears example, and this was easily replaceable. Hope this doesn't break
anybody's code! ;)
Original issue: http://code.google.com/p/pyjamas/issues/detail?id=393 (April 09, 2010 10:48:07)
The text was updated successfully, but these errors were encountered: