Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGCN Hyper parameter optimization error #1367

Closed
3 tasks done
vinven7 opened this issue Feb 18, 2024 · 1 comment · Fixed by #1370
Closed
3 tasks done

RGCN Hyper parameter optimization error #1367

vinven7 opened this issue Feb 18, 2024 · 1 comment · Fixed by #1370
Labels
bug Something isn't working

Comments

@vinven7
Copy link

vinven7 commented Feb 18, 2024

Describe the bug

When I try to use the hpo_pipeline to optimize the RGCN model, I get the error:

TypeError: Model.__init__() got an unexpected keyword argument 'use_batch_norm'

How to reproduce

from pykeen.hpo import hpo_pipeline
hpo_pipeline_result = hpo_pipeline(
    dataset='Nations',
    model='RGCN',
    model_kwargs_ranges=dict(
        embedding_dim=dict(type=int, low=4, high=800, q=50)  # Use 'q' for quantization step
    ),
)

Environment

Key Value
OS posix
Platform Linux
Release 4.18.0-305.19.1.el8_4.x86_64
Time Sun Feb 18 15:29:43 2024
Python 3.10.11
PyKEEN 1.10.1
PyKEEN Hash UNHASHED
PyKEEN Branch
PyTorch 2.0.1
CUDA Available? true
CUDA Version 11.8
cuDNN Version 8700

Additional information

The pipeline itself does not seem to have a problem. The following runs well:

from pykeen.pipeline import pipeline
pipeline_result = pipeline(
    dataset='Nations',
    model='RGCN',
)
pipeline_result.save_to_directory('nations_rgcn')

Issue Template Checks

  • This is not a feature request (use a different issue template if it is)
  • This is not a question (use the discussions forum instead)
  • I've read the text explaining why including environment information is important and understand if I omit this information that my issue will be dismissed
@vinven7 vinven7 added the bug Something isn't working label Feb 18, 2024
cthoyt pushed a commit that referenced this issue Feb 19, 2024
Fix #1367

Also does some repo cleanup due to new versions of black & mypy.

Also fix #1363 by increasing the minimum class-resolver version.
@mberr
Copy link
Member

mberr commented Feb 19, 2024

Hi, this should be solved now. Until our next release, please install from source: https://github.com/pykeen/pykeen?tab=readme-ov-file#installation--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants