Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎣🏆 Repo cleanup and fix RGCN's hpo_default #1370

Merged
merged 15 commits into from
Feb 19, 2024

Conversation

mberr
Copy link
Member

@mberr mberr commented Feb 19, 2024

Fix #1367

Also does some repo cleanup due to new versions of black & mypy.

Also fix #1363 by increasing the minimum class-resolver version.

@mberr mberr changed the title Fix RGCN's hpo_default 🎣🏆 Fix RGCN's hpo_default Feb 19, 2024
@mberr
Copy link
Member Author

mberr commented Feb 19, 2024

the error seems to be equivalent to #1363, and this is something to fix in upstream https://github.com/cthoyt/class-resolver

EDIT: there is already an issue for this: cthoyt/class-resolver#58

@cthoyt
Copy link
Member

cthoyt commented Feb 19, 2024

New v0.4.3 release of class-resolver to PyPI contains the fix. See notes: https://github.com/cthoyt/class-resolver/releases/tag/v0.4.3

@cthoyt
Copy link
Member

cthoyt commented Feb 19, 2024

@mberr can we do a separate PR where we bump the minimum python version? Should we say py310 for now and be relatively progressive?

@mberr
Copy link
Member Author

mberr commented Feb 19, 2024

@mberr can we do a separate PR where we bump the minimum python version? Should we say py310 for now and be relatively progressive?

I would be fine with it (3.10 is also the default Python version in the current Ubuntu LTS).

Is there any reason why we need to bump the version?

@mberr mberr marked this pull request as ready for review February 19, 2024 20:01
@mberr mberr marked this pull request as draft February 19, 2024 20:19
@mberr mberr marked this pull request as ready for review February 19, 2024 20:19
@mberr mberr marked this pull request as draft February 19, 2024 20:42
@mberr mberr marked this pull request as ready for review February 19, 2024 20:42
@cthoyt cthoyt changed the title 🎣🏆 Fix RGCN's hpo_default 🎣🏆 Repo cleanup and fix RGCN's hpo_default Feb 19, 2024
@cthoyt cthoyt merged commit 3a9e1cc into master Feb 19, 2024
9 checks passed
@cthoyt cthoyt deleted the fix-rgcn-default-hpo-ranges branch February 19, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGCN Hyper parameter optimization error Importing model_resolver
2 participants