🔮 💃 Reimplement SE with new-style model #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trigger CI
Trigger CI
Trigger CI
mberr
reviewed
Jul 3, 2021
mberr
reviewed
Jul 3, 2021
Trigger CI
Trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE and NTN are the only two models with EntityEmbeddingModel. I want to upgrade both of them then get rid of that base class. I'm pretty sure when we did the benchmarks these were both ones with improvements over old-style models. Any objections to doing this PR and then another follow-up PR to update NTN?