Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom CAN ID #77

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Add custom CAN ID #77

merged 1 commit into from
Nov 11, 2022

Conversation

Zcholm
Copy link

@Zcholm Zcholm commented Nov 10, 2022

Add support for optional non-standard CAN IDs in addressing modes Mixed 29 bits and NormalFixed 29 bits.

Add test cases for new functionality.

Remove unused internal variable rxmask.

Add support for optional non-standard CAN IDs in addressing modes
Mixed 29 bits and NormalFixed 29 bits.

Add test cases for new functionality.

Remove unused internal variable rxmask.
@pylessard
Copy link
Owner

That's some serious PR! It even have unit tests (more than one!).
Thank you

@pylessard pylessard merged commit 362daa4 into pylessard:master Nov 11, 2022
@pylessard
Copy link
Owner

I'm leaving this here for future references
image

@Zcholm Zcholm deleted the fixture branch November 11, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants