Fix set-env use

[fsoubelet]

Should fix the set-env use in the coverage workflow.
Hopefully fix the warning in the documentation workflow by updating the used version of the github-pages-deploy-action.

Need to open this PR to trigger the first one.

[codeclimate]

Code Climate has analyzed commit 636b983 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.5% (0.0% change).

View more on Code Climate.

[fsoubelet]

That fixed the issue for the coverage workflow: as can be seen here, no more warnings.

I think we can always merge this PR and see what happens with the documentation workflow. Eventually, move to a different gh-pages deploy action or open an issue to the maintainers or the ones we currently use, as I'm fairly sure it is the source of our warning.

@lmalina @mihofer thoughts?

[mihofer]

Fine with me, looking at the deploy repo i couldn't find anything related to that issue since the last version though ...
referencing a specific version by number is necessary or could one just always refer to the latest version to avoid PRs whenever a package is updated? (but likely not needed very often)

[fsoubelet]

looking at the deploy repo i couldn't find anything related to that issue since the last version though

Well indeed, but I really hope the issue comes from them considering I can't find any other possible use of set-env in our documentation workflow.

referencing a specific version by number is necessary or could one just always refer to the latest version to avoid PRs whenever a package is updated? (but likely not needed very often)

Looking at the relevant documentation shows we have many options, and we could for instance choose to specify github-pages-deploy-action@v3 which would use the latest 3.x version available. We can also specify a branch, a SHA, etc.

However, adopting such behavior might be to be discussed with the team first.

[mihofer]

Looking at the relevant documentation shows we have many options, and we could for instance choose to specify github-pages-deploy-action@v3 which would use the latest 3.x version available. We can also specify a branch, a SHA, etc.

However, adopting such behavior might be to be discussed with the team first.

well, actually reads there any way that version should be included

We strongly recommend that you include the version of the action you are using by specifying a Git ref, SHA, or Docker tag number. If you don't specify a version, it could break your workflows or cause unexpected behavior when the action owner publishes an update.

so better leave it as is