Update type annotations of PEP 695 nodes #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These attributes cannot be none in real-world situations, see python/cpython#106145.
jacobtylerwalls
added
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2264 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 94 94
Lines 10951 10951
=======================================
Hits 10161 10161
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Reading the cpython issue it's unclear to me if it was possible it was None in 3.10 and isn't anymore of if this was never possible that it's None. We still need to support older python interpreter if that's the case. |
DanielNoord
approved these changes
Jul 31, 2023
This was only possible in beta's, so making this required is fine imo! |
|
These were new nodes in 3.12, so there's no real-world code that we need to support without these linenos. |
|
Damn, you're really keeping pylint bleeding edge, love that ! |
mbyrnepr2
pushed a commit
to mbyrnepr2/astroid
that referenced
this pull request
Aug 2, 2023
These attributes cannot be none in real-world situations, see python/cpython#106145.
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Aug 5, 2023
…s__ container (#2263) * Exclude type-annotated class attributes, which have no assigned value, from the ``__members__`` container of an ``Enum`` class. Refs pylint-dev/pylint#7402 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix exising test. The value if now `Uninferable` in the case of an annotated attribute of an `enum.Enum` class with no assigned value. * Update astroid/brain/brain_namedtuple_enum.py Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com> * Update tests. * Update test: Use `infer()` instead of `inferred()`. * Update type annotations of PEP 695 nodes (#2264) These attributes cannot be none in real-world situations, see python/cpython#106145. * Update sphinx requirement from ~=7.0 to ~=7.1 (#2265) Updates the requirements on [sphinx](https://github.com/sphinx-doc/sphinx) to permit the latest version. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES) - [Commits](sphinx-doc/sphinx@v7.0.0...v7.1.1) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Ensure a node is inferred in the case when there is only one member. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Undo unintended changes. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2253
These attributes cannot be none in real-world situations, see python/cpython#106145.
@DanielNoord they were already required; we're just changing the type annotations, yes? It's not enforced anywhere in the code.