Add same github actions than pylint but withtout benchmark/spelling #947

Pierre-Sassoulas · 2021-04-17T19:32:44Z

Description

Introduce github action because appveyor is hell and travis is changing his commercial proposal. Also python 3.10 seems to work for astroid so we might as well test it.

Type of Changes

	Type
✓	🔨 Refactoring

Related Issue

cdce8p

Thanks for starting the work here! I never really got to it.

Some general comments:

Should we add the classifier for py310 if the tests already pass?
Travis does run pylint as well. This isn't covered here
The requirement files probably need some work. From looking at the tox.ini file, we probably need to add a requirements_pypy.txt and a requirements_six.txt file as well. https://github.com/PyCQA/astroid/blob/f2b197a4f8af0ceeddf435747a5c937c8632872a/tox.ini#L13-L28
All tests (linux and window) should be run with and without six. Maybe this could work with strategy.matrix?

.travis.yml

requirements_test.txt

requirements_test_pre_commit.txt

requirements_test_min.txt

Pierre-Sassoulas · 2021-04-18T14:41:01Z

I left the x-six and pylint jobs in the travis.yml. Also if the tests are passing without numpy it means we don't need numpy during tests so I removed it in order to be able to have python 3.10.

cdce8p · 2021-04-23T15:48:15Z

I opened #964 and #965 which should simplify this MR, once they are merged.
Can you rebase it as well? It still includes the backports.functools_lru_cache dependency and the issue with requirements_pre_commit.txt which are already fixed.

After those things are done, I believe we only need to check that all the right requirements are installed and the cache key is generated correctly and it should be good to go. Maybe we should also pin the requirements in requirements_test_brain.txt?

If you like, let me know once you're done with the rebase and I can take another look regarding the dependencies.

Pierre-Sassoulas · 2021-04-23T16:03:40Z

#965 is not mergeable right now, I tried to do it too but we need to think about why six or not six is required for tests (I don't know much about six). So I think this is reviewable now.

But withtout benchmark and speeling that are specific to pylint.

cdce8p

Only a few small things, mainly requirements_test_brain.txt. That file isn't loaded inside requirements_test.txt, which is the right decision, so it needs to be installed manually.

appveyor.yml

.travis.yml

.github/workflows/ci.yaml

cdce8p · 2021-04-23T20:20:40Z

.github/workflows/ci.yaml

+          python -m venv venv
+          . venv/bin/activate
+          python -m pip install -U pip setuptools wheel
+          pip install -U -r requirements_test.txt


Suggested change

pip install -U -r requirements_test.txt

pip install -U -r requirements_test.txt -r requirements_test_brain.txt

Any specific reason why you didn't add this one here?

No my bad !

Do you what do fix it or shall I? :)

I'll fix in a MR for fixing pylint's warning again. (pylint's master changed)

We should probably pin the pylint version for the formatting checks

Yeah I thought that as well, we don't want to have to fix unrelated pylint warning in a MR just because pylint changed.

See : https://github.com/PyCQA/astroid/pull/968/files

.github/workflows/ci.yaml

cdce8p · 2021-04-23T21:21:34Z

.travis.yml

-    - python: pypy3
-      env: TOXENV=pypy
-    - python: 3.6
-      env: TOXENV=py36,py36-six


Just noticed, we probably broke the deploy stage by removing py36 here.

It was already broken but not the same way 😄 If you want to fix it feel free.. I'm aiming to fix pylint's warning and finish #937 before releasing 2.5.4

See https://github.com/PyCQA/astroid/pull/947\#discussion_r619497973

Pierre-Sassoulas added the task label Apr 17, 2021

Pierre-Sassoulas force-pushed the add-github-actions branch from f2f1746 to 9a8929b Compare April 17, 2021 19:37

Pierre-Sassoulas changed the title ~~Add same github actions than pylint but withtout benchmark~~ Add same github actions than pylint but withtout benchmark/spelling Apr 17, 2021

Pierre-Sassoulas requested a review from cdce8p April 17, 2021 19:58

Pierre-Sassoulas mentioned this pull request Apr 17, 2021

Upgrade packaging to setuptools #937

Merged

Pierre-Sassoulas added this to the 2.5.4 milestone Apr 17, 2021

cdce8p requested changes Apr 17, 2021

View reviewed changes

.travis.yml Show resolved Hide resolved

requirements_test.txt Outdated Show resolved Hide resolved

requirements_test_pre_commit.txt Outdated Show resolved Hide resolved

requirements_test_min.txt Outdated Show resolved Hide resolved

Pierre-Sassoulas mentioned this pull request Apr 18, 2021

Read the doc integration #949

Merged

Pierre-Sassoulas force-pushed the add-github-actions branch 4 times, most recently from df19a76 to f190b68 Compare April 18, 2021 14:38

Pierre-Sassoulas requested a review from cdce8p April 18, 2021 14:39

Pierre-Sassoulas mentioned this pull request Apr 18, 2021

Fix pylint legacy warnings #950

Merged

Pierre-Sassoulas force-pushed the add-github-actions branch 2 times, most recently from 7f092b3 to f88f80c Compare April 20, 2021 07:51

Pierre-Sassoulas mentioned this pull request Apr 20, 2021

Refactor the requirements in tox.ini #957

Merged

Pierre-Sassoulas force-pushed the add-github-actions branch 2 times, most recently from 8605cfc to 89088ec Compare April 21, 2021 21:19

This was referenced Apr 22, 2021

Remove backports.functools_lru_cache dependency #959

Merged

Fix pre_commit requirements #961

Merged

Add black-disable-checker #964

Merged

Consolidate test cases #965

Merged

Pierre-Sassoulas force-pushed the add-github-actions branch from dc40751 to 3a75027 Compare April 23, 2021 16:01

Pierre-Sassoulas force-pushed the add-github-actions branch 2 times, most recently from cc0d8d1 to eed67ba Compare April 23, 2021 19:24

Pierre-Sassoulas mentioned this pull request Apr 23, 2021

Support python 3.10 #966

Closed

Pierre-Sassoulas force-pushed the add-github-actions branch 2 times, most recently from df4cff4 to a6b1031 Compare April 23, 2021 19:45

Pierre-Sassoulas added 4 commits April 23, 2021 21:54

Add same github actions than pylint

8998255

But withtout benchmark and speeling that are specific to pylint.

Remove appveyor since github actions was added

86050e4

Modify the key to release to pypi to the one from pylint

5819f6a

Remove what is done in github action from the travis.yml

d220646

Pierre-Sassoulas force-pushed the add-github-actions branch from a6b1031 to d220646 Compare April 23, 2021 19:54

cdce8p requested changes Apr 23, 2021

View reviewed changes

cdce8p added Waiting on author and removed Waiting on author labels Apr 23, 2021

Pierre-Sassoulas added a commit that referenced this pull request Apr 23, 2021

Apply hashing and depencencies suggestions (review #947)

02013b2

Pierre-Sassoulas added 2 commits April 23, 2021 23:02

Remove job that are already checked by github actions

e611ad8

Apply hashing and depencencies suggestions (review #947)

363a88b

Pierre-Sassoulas force-pushed the add-github-actions branch from 02013b2 to 363a88b Compare April 23, 2021 21:02

Pierre-Sassoulas merged commit 682ec6d into master Apr 23, 2021

Pierre-Sassoulas deleted the add-github-actions branch April 23, 2021 21:06

cdce8p reviewed Apr 23, 2021

View reviewed changes

Pierre-Sassoulas referenced this pull request Apr 23, 2021

Fix forgotten requirement in CI

c9f2783

See https://github.com/PyCQA/astroid/pull/947\#discussion_r619497973

Pierre-Sassoulas referenced this pull request Apr 24, 2021

Fix forgotten requirement in CI

ca4e01a

See https://github.com/PyCQA/astroid/pull/947\#discussion_r619497973

Pierre-Sassoulas referenced this pull request Apr 24, 2021

Fix forgotten requirement in CI

995ac9e

See https://github.com/PyCQA/astroid/pull/947\#discussion_r619497973

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add same github actions than pylint but withtout benchmark/spelling #947

Add same github actions than pylint but withtout benchmark/spelling #947

Pierre-Sassoulas commented Apr 17, 2021 •

edited

Loading

cdce8p left a comment

Pierre-Sassoulas commented Apr 18, 2021 •

edited

Loading

cdce8p commented Apr 23, 2021

Pierre-Sassoulas commented Apr 23, 2021

cdce8p left a comment

cdce8p Apr 23, 2021

cdce8p Apr 23, 2021

Pierre-Sassoulas Apr 23, 2021

cdce8p Apr 23, 2021

Pierre-Sassoulas Apr 23, 2021

cdce8p Apr 23, 2021

Pierre-Sassoulas Apr 23, 2021

cdce8p Apr 23, 2021

Pierre-Sassoulas Apr 23, 2021

	pip install -U -r requirements_test.txt
	pip install -U -r requirements_test.txt -r requirements_test_brain.txt

Add same github actions than pylint but withtout benchmark/spelling #947

Add same github actions than pylint but withtout benchmark/spelling #947

Conversation

Pierre-Sassoulas commented Apr 17, 2021 • edited Loading

Description

Type of Changes

Related Issue

cdce8p left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Apr 18, 2021 • edited Loading

cdce8p commented Apr 23, 2021

Pierre-Sassoulas commented Apr 23, 2021

cdce8p left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Apr 17, 2021 •

edited

Loading

Pierre-Sassoulas commented Apr 18, 2021 •

edited

Loading