test_linter_should_be_pickable fails

[mweinelt]

We are seeing the following test failure on 0.7 with python 3.9.12 and pylint 2.13.5.

_______________________ test_linter_should_be_pickleable _______________________

linter = Checker 'master' (responsible for 'F0001', 'F0002', 'F0010', 'F0011', 'I0001', 'I0010', 'I0011', 'I0013', 'I0020', 'I0021', 'I0022', 'E0001', 'E0011', 'E0012', 'E0013', 'E0014')

    def test_linter_should_be_pickleable(linter):
        # Setup
        linter.register_checker(TypeChecker())
        augment_visit(linter, TypeChecker.visit_attribute, fake_augmentation_func)
        suppress_message(
            linter, TypeChecker.visit_attribute, "no-member", fake_suppress_func
        )
    
        # Act and Assert
>       pickle.dumps(linter)
E       TypeError: cannot pickle 'EncodedFile' object

tests/test_linter_pickle.py:25: TypeError

[DanielNoord]

This is likely due to our switch to dill to pickle the PyLinter object.

Package can be found over at https://github.com/uqfoundation/dill.

[mweinelt]

Our pylint package already had dill 0.3.4 at that point, and it's still reproducible for us.

[DanielNoord]

No but the test seems to use pickle.dumps() which will never be able to pickle linter as pickle doesn't support pickling PyLinter.

[carlio]

This has been fixed on master so I will close it now and make a release tomorrow.