Support for pylint 3 & python 3.12

[irtazaakram]

Hi,

This PR

• adds support for pylint 3
• adds support for python 3.12
• drops support for python 3.6 & 3.7 (EOL)

Can we please have a new release after this PR is merged.

Thanks,

Fixes #11
Fixes #12

[irtazaakram]

Hi @stdedos,
can you please review this.
Thanks,

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e73cc2f) 92.03% compared to head (d5c61a8) 91.96%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   92.03%   91.96%   -0.07%     
==========================================
  Files          18       18              
  Lines         527      523       -4     
  Branches       99       99              
==========================================
- Hits          485      481       -4     
  Misses         29       29              
  Partials       13       13              

Flag	Coverage Δ
3.10	91.77% <ø> (-0.07%)	⬇️
3.11	91.77% <ø> (-0.07%)	⬇️
3.12	91.77% <ø> (?)
3.6	?
3.7	?
3.8	91.77% <ø> (-0.07%)	⬇️
3.9	91.77% <ø> (-0.07%)	⬇️
macos-latest	91.77% <ø> (-0.07%)	⬇️
ubuntu-20.04	?
ubuntu-latest	91.77% <ø> (-0.07%)	⬇️
windows-latest	91.77% <ø> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pylint_pytest/checkers/class_attr_loader.py	92.85% <ø> (-0.48%)	⬇️
pylint_pytest/checkers/fixture.py	90.29% <ø> (-0.19%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stdedos]

The v2.0 I'm estimating to be released mid-November

Setting this as blocked

[stdedos]

For the failing actions, you might want to revert b3e8974

[irtazaakram]

Hi @stdedos,
Thank you for taking time to review this PR. Much appreciated.

[stdedos]

Thank you for offering the code @irtazaakram ❤️

[irtazaakram]

hi @stdedos,
do you know what happened here? I see the banner Pull request successfully merged and closed and it aslo says I closed it even though i never did?

[stdedos]

That is ... interesting 😕

All I can see is this

Something-something with your force-pushes, but I must run for now and I haven't checked what happened there 😅

[irtazaakram]

🤦🏻 let me know if i should open a new PR? as I am also not able to reopen it.

[stdedos]

I think it should be something obvious we are both missing

Also, GitHub is somewhat too magic sometimes for my taste 😅

[irtazaakram]

hey @stdedos, I mistakenly forced pushed commit without any changes while trying to revert b3e8974
🤦🏻 and thats what caused this PR to close.

PR is ready now. Let me know if there are any changes that you want to suggest.

again apologies for this.

Thank you

[stdedos]

Hey @irtazaakram

pre-commit says this:

(https://results.pre-commit.ci/run/github/602434841/1698218743.HAiZ2fOQR3-yD9koSvOV5w)

You'd have to either apply the changes, or allow pre-commit to apply those changes 😕

[irtazaakram]

These changes causes tests to fail for python 3.8 & 3.9

[stdedos]

https://github.com/pylint-dev/pylint-pytest/actions/runs/6637112680/job/18031541929?pr=22

I will eventually handle some of those pylint issues

[stdedos]

The MR looks solid - and we need to figure out a solution for Windows-testing.

Amazing job @irtazaakram 🚀

[Pierre-Sassoulas]

I can't write directly on this branch but the fix for pylint's check is this: 904e2e9

[Pierre-Sassoulas]

Closing in favor of two other merge requests: #23 then #24. Thank you for your work @irtazaakram I credited you in the rebased commit.