Drop python 3.6 and 3.7 which are past end of life upstream #23

Pierre-Sassoulas · 2023-11-04T09:23:51Z

Cherry-picked from #8, I'm doing things progressively so it's reviewable.

Closes #11

codecov · 2023-11-04T09:25:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48212e2) 94.16% compared to head (f6e9b9e) 93.97%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   94.16%   93.97%   -0.19%     
==========================================
  Files          18       18              
  Lines         548      548              
  Branches      106      106              
==========================================
- Hits          516      515       -1     
  Misses         23       23              
- Partials        9       10       +1

Flag	Coverage Δ
3.10	`93.97% <ø> (ø)`
3.11	`93.97% <ø> (ø)`
3.6	`?`
3.7	`?`
3.8	`93.97% <ø> (ø)`
3.9	`93.97% <ø> (ø)`
macos-latest	`93.97% <ø> (ø)`
ubuntu-20.04	`?`
ubuntu-latest	`93.97% <ø> (ø)`
windows-latest	`93.97% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pierre-Sassoulas · 2023-11-04T09:32:46Z

@stdedos I think it could be merged even with the negative coverage change.

Pierre-Sassoulas · 2023-11-11T22:23:04Z

@stdedos could you review this, please :) ? The CI is red because of an indirect coverage changes that I think we can ignore.

stdedos · 2023-11-11T22:39:16Z

@stdedos could you review this, please :) ? The CI is red because of an indirect coverage changes that I think we can ignore.

Yeah, this seems to be the problem:

https://app.codecov.io/gh/pylint-dev/pylint-pytest/pull/23/indirect-changes

I'd be nice to figure out why is this happening, but it is definitely not a priority - given the benefits of this PR.

"I am not reviewing this" since it's not scheduled to go in yet.
Otherwise all looks golden to me and it is approved 💚

Plan is:

New bugfix on Monday 13.11
Merge 🐛 Ignore collection failures in non-tests #15
Merge whatever else minor comes in (like Windows Artifacts have incorrect Slugification #25, A collection of minor improvements to tests #26)
New bugfix on Monday 20.11
Questions
Start https://github.com/pylint-dev/pylint-pytest/milestone/2
New b/rc asap

Question:

Can Add python 3.12 support in CI and metadata #24 become thinner? I could consider it for v1
Can Support pylint v3 #12 be fixed for v1? I lost track on what was the pylint issue 😅

Pierre-Sassoulas · 2023-11-17T08:21:44Z

Can #24 become thinner? I could consider it for v1

We can remove the drop of python 3.6 / 3.7 (probably)

Can #12 be fixed for v1? I lost track on what was the pylint issue 😅

Need to support 3.12 maybe something else

stdedos · 2023-11-17T10:16:32Z

Can #24 become thinner? I could consider it for v1

We can remove the drop of python 3.6 / 3.7 (probably)

I'd consider it for v1 - but it doesn't have to wait "the usual" 1w-period.

So next week we release master, and a thin #24 afterwards

#8 (comment)

Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com>

Pierre-Sassoulas · 2023-11-27T21:05:43Z

Hey, I tried dropping the removal of python 3.6 / 3.7 and simply adding python 3.12, but this is non trivial (https://github.com/pylint-dev/pylint-pytest/actions/runs/7010519218/job/19071209667?pr=24). It's been nearly two months since the release of python 3.12 / pylint 3.0 and python 3.6 / 3.7 have been EOL for a long time, maybe we could just drop EOL interpreters and release 2.X serie, what do you think ?

Pierre-Sassoulas · 2023-11-27T21:08:04Z

See this issue in vscode/pylint : microsoft/vscode-pylint#460 for example

stdedos · 2023-11-28T06:18:59Z

Thank you for trying ❤️

Sadly, my OSS time has been near-zero these days.
I will make it my first priority to merge these.

Pierre-Sassoulas · 2023-11-28T06:59:11Z

No problem. This one is ready the coverage drop is acceptable imo.

pyproject.toml

stdedos

Must be merged after #27, if it becomes ready for a Monday release

stdedos · 2023-12-03T19:23:57Z

I took the liberty to prepare this for tomorrow 🙃

* master: Update/Prepare Changelog for v1.1.7 use pylint v3 in the repo remove support of pylint v1 Support pylint v3 Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> Additionally, some minor format modifications at `CHANGELOG.md`

Pierre-Sassoulas · 2023-12-03T21:12:04Z

Thank you @stdedos :)

stdedos · 2023-12-04T07:12:26Z

Thank you @Pierre-Sassoulas for all your contributions and patience 😁 🙏

# Added * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Introduced @dependabot (part of #28) * Improved reliability of the `FixtureChecker` class (#29) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Pierre-Sassoulas added the enhancement New feature or request label Nov 4, 2023

Pierre-Sassoulas force-pushed the drop-eol-python-add-3.12 branch from 7a58c82 to 1ef687a Compare November 4, 2023 09:25

Pierre-Sassoulas force-pushed the drop-eol-python-add-3.12 branch from 1ef687a to 89b7034 Compare November 4, 2023 09:32

Pierre-Sassoulas requested a review from stdedos November 4, 2023 09:32

Pierre-Sassoulas mentioned this pull request Nov 4, 2023

Add python 3.12 support in CI and metadata #24

Closed

Pierre-Sassoulas force-pushed the drop-eol-python-add-3.12 branch from 89b7034 to bc95dc1 Compare November 4, 2023 09:41

Pierre-Sassoulas mentioned this pull request Nov 4, 2023

Support for pylint 3 & python 3.12 #22

Closed

stdedos added this to the Release v2 milestone Nov 11, 2023

Pierre-Sassoulas and others added 3 commits November 27, 2023 21:46

Move everything from the setup.cfg to pyproject.toml

7599c01

Drop python 3.6 and 3.7

bb6dfc8

#8 (comment)

Upgrade python version to python 3.8 in tooling configuration

65fa52b

Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com>

Pierre-Sassoulas force-pushed the drop-eol-python-add-3.12 branch from fd067e9 to 65fa52b Compare November 27, 2023 20:52

stdedos mentioned this pull request Dec 1, 2023

Support pylint v3 #12

Closed

stdedos reviewed Dec 2, 2023

View reviewed changes

pyproject.toml Show resolved Hide resolved

stdedos approved these changes Dec 2, 2023

View reviewed changes

stdedos added the blocked label Dec 2, 2023

stdedos force-pushed the drop-eol-python-add-3.12 branch from f1e6197 to f6e9b9e Compare December 3, 2023 19:24

stdedos removed the blocked label Dec 3, 2023

Pierre-Sassoulas merged commit 57a868b into master Dec 3, 2023
30 of 31 checks passed

Pierre-Sassoulas deleted the drop-eol-python-add-3.12 branch December 3, 2023 21:12

This was referenced Dec 3, 2023

rework dev dependencies management #28

Merged

Drop Python 3.6 + 3.7 #11

Closed

stdedos restored the drop-eol-python-add-3.12 branch December 4, 2023 06:48

Pierre-Sassoulas deleted the drop-eol-python-add-3.12 branch December 6, 2023 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop python 3.6 and 3.7 which are past end of life upstream #23

Drop python 3.6 and 3.7 which are past end of life upstream #23

Pierre-Sassoulas commented Nov 4, 2023 •

edited by stdedos

Loading

codecov bot commented Nov 4, 2023 •

edited

Loading

Pierre-Sassoulas commented Nov 4, 2023

Pierre-Sassoulas commented Nov 11, 2023

stdedos commented Nov 11, 2023

Pierre-Sassoulas commented Nov 17, 2023

stdedos commented Nov 17, 2023

Pierre-Sassoulas commented Nov 27, 2023

Pierre-Sassoulas commented Nov 27, 2023

stdedos commented Nov 28, 2023

Pierre-Sassoulas commented Nov 28, 2023

stdedos left a comment

stdedos commented Dec 3, 2023

Pierre-Sassoulas commented Dec 3, 2023

stdedos commented Dec 4, 2023

Drop python 3.6 and 3.7 which are past end of life upstream #23

Drop python 3.6 and 3.7 which are past end of life upstream #23

Conversation

Pierre-Sassoulas commented Nov 4, 2023 • edited by stdedos Loading

codecov bot commented Nov 4, 2023 • edited Loading

Codecov Report

Pierre-Sassoulas commented Nov 4, 2023

Pierre-Sassoulas commented Nov 11, 2023

stdedos commented Nov 11, 2023

Pierre-Sassoulas commented Nov 17, 2023

stdedos commented Nov 17, 2023

Pierre-Sassoulas commented Nov 27, 2023

Pierre-Sassoulas commented Nov 27, 2023

stdedos commented Nov 28, 2023

Pierre-Sassoulas commented Nov 28, 2023

stdedos left a comment

Choose a reason for hiding this comment

stdedos commented Dec 3, 2023

Pierre-Sassoulas commented Dec 3, 2023

stdedos commented Dec 4, 2023

Pierre-Sassoulas commented Nov 4, 2023 •

edited by stdedos

Loading

codecov bot commented Nov 4, 2023 •

edited

Loading