Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkers do not respect priority #229

Closed
pylint-bot opened this issue May 3, 2014 · 2 comments
Closed

Checkers do not respect priority #229

pylint-bot opened this issue May 3, 2014 · 2 comments
Labels

Comments

@pylint-bot
Copy link

Originally reported by: Anonymous


Looked through the code base and though it does read it in and assert that the chercker priority is not greater than zero, it never actually uses the priority for anything.

I hacked in a fix in my local copy of the code

checkers.sort(key=attrgetter('priority'), reverse=True)

in line 600 of lint.py, right after
checkers = self.prepare_checkers()

And that seems to work fine.
You also need
from operator import attrgetter
for the sorting method/


@pylint-bot
Copy link
Author

Original comment by Claudiu Popa (BitBucket: PCManticore, GitHub: @PCManticore):


Hi. Would you like to submit a pull request for this?

@pylint-bot
Copy link
Author

Original comment by Claudiu Popa (BitBucket: PCManticore, GitHub: @PCManticore):


Checkers respect priority now. Close issue #229.

msuozzo pushed a commit to msuozzo/pylint that referenced this issue Feb 18, 2022
Also, drop fossil script (created with old name).

Closes pylint-dev#227.
Closes pylint-dev#228.
Closes pylint-dev#229.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant