-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return type checkers calls on ellipses functions #5107
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8411e7a
Fix return type checkers calls on ellipses functions
DanielNoord fb9cc57
Update pylint/checkers/classes.py
DanielNoord c1a7c9a
Code review
DanielNoord 87a7f1e
Fix return type of `__repr__` in test
DanielNoord 0225998
Move class string
DanielNoord 2209671
Merge branch 'main' of https://github.com/PyCQA/pylint into return-ty…
DanielNoord 2320fa7
Re-move docstring
DanielNoord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
""""Tests for return type checkers for protocol methods with ellipsis function body | ||
The "invalid-*-returned" messages shouldn't be emitted for stub functions | ||
Original issue: https://github.com/PyCQA/pylint/issues/4736""" | ||
# pylint: disable=missing-class-docstring | ||
from typing import Any, Iterator | ||
|
||
|
||
class MyClass: | ||
DanielNoord marked this conversation as resolved.
Show resolved
Hide resolved
|
||
def __len__(self) -> int: | ||
... | ||
|
||
def __hash__(self) -> int: | ||
... | ||
|
||
def __index__(self) -> int: | ||
... | ||
|
||
def __iter__(self) -> Iterator[Any]: | ||
... | ||
|
||
def __bool__(self) -> bool: | ||
... | ||
|
||
def __repr__(self) -> object: | ||
... | ||
|
||
def __str__(self) -> str: | ||
... | ||
|
||
def __bytes__(self) -> bytes: | ||
... | ||
|
||
def __length_hint__(self) -> int: | ||
... | ||
|
||
def __format__(self, format_spec: str) -> str: | ||
... | ||
|
||
def __getnewargs__(self) -> tuple: | ||
... | ||
|
||
def __getnewargs_ex__(self) -> tuple: | ||
... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move these just before the class definition? Someone might add additional test cases later on. That way at least the general docstring will stay up to date.