Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of metaclasses of Undefined-variable checker #5179

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Improve handling of metaclasses of Undefined-variable checker #5179

merged 2 commits into from
Oct 18, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

This closes #4021 and #4031

#4021 was actually already fixed before, but I stumbled across it will looking for similar undefined-variable checker issues.

@DanielNoord DanielNoord added the False Negative 🦋 No message is emitted but something is wrong with the code label Oct 18, 2021
@DanielNoord DanielNoord added this to the 2.12.0 milestone Oct 18, 2021
@DanielNoord DanielNoord changed the title Undefined Improve handling of metaclasses of Undefined-variable checker Oct 18, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1354732705

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.251%
Totals Coverage Status
Change from base Build 1352191945: 0.003%
Covered Lines: 13638
Relevant Lines: 14625
💛 - Coveralls

@DanielNoord DanielNoord merged commit 1daee40 into pylint-dev:main Oct 18, 2021
@DanielNoord DanielNoord deleted the undefined branch October 18, 2021 14:04
@DanielNoord DanielNoord linked an issue Oct 18, 2021 that may be closed by this pull request
Undefined values to class keyword arguments (including metaclass) not caught. #4031
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
False Negative 🦋 No message is emitted but something is wrong with the code
Projects
None yet
Milestone
2.12.0
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas