Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'nonexistent-operator' to allow repeated unary ops (with space or parens) #6008

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Change 'nonexistent-operator' to allow repeated unary ops (with space or parens) #6008

merged 2 commits into from
Mar 29, 2022

Conversation

skirpichev
Copy link
Contributor

Type of Changes

Type
✓ 🐛 Bug fix

Description

This PR relax requirements for the 'nonexistent-operator' checker to allow repeated unary ops, separated by spaces or with parens.

Closes #5769

@coveralls
Copy link

coveralls commented Mar 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2051582503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 94.154%
Files with Coverage Reduction New Missed Lines %
pylint/checkers/base/name_checker/checker.py 1 99.2%
Totals Coverage Status
Change from base Build 2047793050: 0.0%
Covered Lines: 15334
Relevant Lines: 16286
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I think it should go in 2.13.3

ChangeLog Outdated Show resolved Hide resolved
doc/whatsnew/2.14.rst Outdated Show resolved Hide resolved
@skirpichev
Copy link
Contributor Author

I think it should go in 2.13.3

Should I remove entry in the whatsnew/2.14.rst?

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Mar 28, 2022 •
edited
Loading

No it's ok, only move in the changelog file (I use that for release note).

@skirpichev
Copy link
Contributor Author

No it's ok, only move in the changelog file (I use that for release note).

Not sure I understand you. There are entries in the changelog file and whatsnew/2.14.rst. Should I preserve both?

PS: test failure sees unrelated.

@Pierre-Sassoulas Pierre-Sassoulas added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer False Positive 🦟 A message is emitted but nothing is wrong with the code labels Mar 28, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.3 milestone Mar 28, 2022
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if it was unclear. We decided in another MR to also include maintenance fix in what's new for 2.13. Thank you for the fix !

@DanielNoord DanielNoord merged commit 0227e7f into pylint-dev:main Mar 29, 2022
@skirpichev skirpichev deleted the fix-5769 branch March 29, 2022 06:43
Pierre-Sassoulas added a commit that referenced this pull request Mar 29, 2022
@skirpichev @Pierre-Sassoulas
Change 'nonexistent-operator' to allow repeated unary ops (with space…
a880bd6 
… or parens) (#6008)

Closes #5769

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.3
Development

Successfully merging this pull request may close these issues.

False positive 'nonexistent-operator' for repeated '-' (with parens)
4 participants
@skirpichev @coveralls @Pierre-Sassoulas @DanielNoord