Change 'nonexistent-operator' to allow repeated unary ops (with space…

… or parens) (#6008) Closes #5769 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
pylint-dev · Mar 29, 2022 · 0227e7f · 0227e7f
1 parent 44ddbdf
commit 0227e7f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 0 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -45,6 +45,11 @@ Release date: TBA
 
   Closes #5998
 
+* Fix false positive for 'nonexistent-operator' when repeated '-' are
+  separated (e.g. by parens).
+
+  Closes #5769
+
 
 What's New in Pylint 2.13.2?
 ============================

diff --git a/doc/whatsnew/2.13.rst b/doc/whatsnew/2.13.rst
@@ -566,3 +566,8 @@ Other Changes
   "return (a or b) in iterable".
 
   Closes #5803
+
+* Fix false positive for 'nonexistent-operator' when repeated '-' are
+  separated (e.g. by parens).
+
+  Closes #5769
diff --git a/pylint/checkers/base/basic_error_checker.py b/pylint/checkers/base/basic_error_checker.py
@@ -387,6 +387,7 @@ def visit_unaryop(self, node: nodes.UnaryOp) -> None:
             (node.op in "+-")
             and isinstance(node.operand, nodes.UnaryOp)
             and (node.operand.op == node.op)
+            and (node.col_offset + 1 == node.operand.col_offset)
         ):
             self.add_message("nonexistent-operator", node=node, args=node.op * 2)
 

diff --git a/tests/functional/n/nonexistent_operator.py b/tests/functional/n/nonexistent_operator.py
@@ -13,3 +13,7 @@
 b = a
 --a # [nonexistent-operator]
 c = (--a) * b # [nonexistent-operator]
+c = -(-a)
+c = +(+a)
+c = - -a
+c = + +a