-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TODOs in unused-variable
tests
#6162
Conversation
Further discussion suggested making no changes (one warning per name per scope).
# pylint: disable=redefined-outer-name, wrong-import-position,misplaced-future | ||
# pylint: disable=wrong-import-position,misplaced-future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was worth surfacing the redefined-outer-name
in these tests so you can more easily see that some warning is raised for the fishiness.
unused-variable
tests
Pull Request Test Coverage Report for Build 2085453651
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup !
I'm looking into the behavior change -- see pylint run. Whether I have to restore the special case or not I'll add a functional test. |
Hmm. Whatever it is belongs in another PR. Haven't narrowed it down yet. I'll restore the code I thought was useless, and then this can keep moving. |
Type of Changes
Description
Per discussion on #4391, which we closed, I think we can stick to the one-warning-per-variable-per-scope contract, so these TODOs are out of date.
If we want to look into adding warnings, we can do it more broadly in #5838.