Remove TODOs in unused-variable tests
#6162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further discussion suggested making no changes (one warning per name per scope).
jacobtylerwalls
added
the
Maintenance
jacobtylerwalls
commented
Apr 3, 2022
| # pylint: disable=redefined-outer-name, wrong-import-position,misplaced-future | ||
| # pylint: disable=wrong-import-position,misplaced-future |
There was a problem hiding this comment.
I thought it was worth surfacing the redefined-outer-name in these tests so you can more easily see that some warning is raised for the fishiness.
jacobtylerwalls
changed the title
unused-variable tests
Pull Request Test Coverage Report for Build 2085453651
💛 - Coveralls |
|
I'm looking into the behavior change -- see pylint run. Whether I have to restore the special case or not I'll add a functional test. |
|
Hmm. Whatever it is belongs in another PR. Haven't narrowed it down yet. I'll restore the code I thought was useless, and then this can keep moving. |
Pierre-Sassoulas
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Per discussion on #4391, which we closed, I think we can stick to the one-warning-per-variable-per-scope contract, so these TODOs are out of date.
If we want to look into adding warnings, we can do it more broadly in #5838.