Flag superfluous-parens if parentheses are used during string concatenation.
#7752
Conversation
| hi = ("CONST",) | ||
|
|
||
| #TODO: maybe get this line to report [superfluous-parens] without causing other false positives. | ||
| assert "" + ("Version " + "String") in Z |
There was a problem hiding this comment.
alright so this is a legitimate case for raising superlous-parens and was brought up in the issue, but I cannot fix it without causing other bigger issues. I think it's probably ok to leave this as a false negative?
clavedeluna
force-pushed
the
4792-superf-parens
branch
from
dcae0f5
to
b8334ed
Compare
Pierre-Sassoulas
added
Enhancement ✨
|
Do you know what's up with the |
|
Do you know what's up with the alternative-union-syntax test failure? Fixed. Disabling superfulous-parens in alternative_union_syntax:52 is reasonable given that we aren't testing for that, but also the msg being raised is also correct there bc CustomTypedDict = TypedDict("CustomTypedDict", my_var=(int | str)) == CustomTypedDict = TypedDict("CustomTypedDict", my_var=int | str) |
Pull Request Test Coverage Report for Build 3455686088
💛 - Coveralls |
clavedeluna
force-pushed
the
4792-superf-parens
branch
from
4198826
to
1f98ceb
Compare
This comment has been minimized.
This comment has been minimized.
|
I looked at some of the primer outputs and it actually seems like this is working exactly as we want! |
clavedeluna
force-pushed
the
4792-superf-parens
branch
from
1f98ceb
to
2226312
Compare
This comment has been minimized.
This comment has been minimized.
|
Sorry, one more thing. You could change the news fragment to end with |
Type of Changes
Description
Closes #4792
This PR ensures that
superfluous-parensis emitted if str concatenation is happening but the parentheses are not necessary, that is without the parens the concat result is the same as with them.