-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hanging forever after a parallel job was killed #7834
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fc1baf7
Replace multiprocessing.pool with concurrent.futures.ProcessPoolExecuβ¦
daniel-wer d5e17d8
Fix initargs parameter to be a tuple.
daniel-wer 2657772
add whatsnew fragment
daniel-wer 2e47049
Add a test that an error in the initializer for the parallel jobs, doβ¦
daniel-wer 236e5e9
Increase timeout for parallel initializer test to avoid flakiness.
daniel-wer 61b8342
Guard concurrent.futures imports, because they are not available in Eβ¦
daniel-wer a52cb6c
Check availability of concurrent.futures module instead of multiproceβ¦
daniel-wer 30af13a
Small fixes
DanielNoord e164bea
Update tests/test_check_parallel.py
daniel-wer 69729db
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Pylint will no longer deadlock if a parallel job is killed but fail | ||
immediately instead. | ||
|
||
Closes #3899 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one use of this still, it is used to get the id of the process. Can we do that with
concurrent
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that's not possible with
concurrent
. As I wrote in my last comment, "this kind of functionality was not duplicated for theconcurrent.futures
module which is rather an alternative interface for interacting with a process pool but not changing the underlying process fundamentals likecurrent_process()
orcpu_count()
". Theconcurrent
module is usingmultiprocessing
internally, it is not supposed to be a replacement.