Fix ModuleNotFoundError when using pylint_django #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the import path is fixed up before calling ._astroid_module_checker() so that the pylint_django plugin can successfully import the Django settings module when its checkers are initialized.
Pull Request Test Coverage Report for Build 3695649934
💛 - Coveralls |
Pierre-Sassoulas
added
Bug 🪲
Downstream Bug 🪲
Pierre-Sassoulas
removed
the
Downstream Bug 🪲
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 1cc95a5 |
|
@Pierre-Sassoulas |
Pierre-Sassoulas
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Thank you for the subtle fix @living180 👍
@DanielNoord : It's a new cache that is buggy, it started when a dependency change made the python 3.8 env be regenerated I think. This branch is probably using the old cache.
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Dec 14, 2022
Ensure that the import path is fixed up before calling ._astroid_module_checker() so that the pylint_django plugin can successfully import the Django settings module when its checkers are initialized. Closes #7938 (cherry picked from commit 491eef5) Co-authored-by: Daniel Harding <dharding@living180.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the import path is fixed up before calling
._astroid_module_checker()so that thepylint_djangoplugin can successfully import the Django settings module when its checkers are initialized.Closes #7938