Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to astroid 2.15.0 #8387

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature

Description

Refs #8385

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Mar 6, 2023
@Pierre-Sassoulas Pierre-Sassoulas removed the Skip news 🔇 This change does not require a changelog entry label Mar 6, 2023
doc/whatsnew/fragments/8387.feature Outdated Show resolved Hide resolved
pylint/pyreverse/inspector.py Outdated Show resolved Hide resolved
Pierre-Sassoulas and others added 2 commits March 6, 2023 15:14
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@Pierre-Sassoulas
Copy link
Member Author

I'm not sure at all that the replacement I used for 'is_standard_module is the right one. there was a lot of thing done in the original function, not sure if it's a one to one replacement. And as we saw the tests are not catching basic mistakes.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #8387 (cb51939) into main (47cb11f) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8387      +/-   ##
==========================================
+ Coverage   95.56%   95.57%   +0.01%     
==========================================
  Files         178      178              
  Lines       18765    18763       -2     
==========================================
  Hits        17932    17932              
+ Misses        833      831       -2     
Impacted Files Coverage Δ
pylint/checkers/typecheck.py 96.35% <ø> (ø)
pylint/pyreverse/inspector.py 79.64% <33.33%> (+0.69%) ⬆️
pylint/checkers/imports.py 94.33% <100.00%> (ø)
pylint/pyreverse/writer.py 100.00% <100.00%> (ø)

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.0 milestone Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

🤖 Effect of this PR on checked open source code: 🤖

Effect on music21:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'midiEventList' is unsubscriptable
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/midi/translate.py#L1359

Effect on sentry:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value '_from_email_domain_cache' is unsubscriptable
    https://github.com/getsentry/sentry/blob/241223720f050fe400725885db77eac922bf107c/src/sentry/utils/email/address.py#L26

This comment was generated for commit cb51939

@DanielNoord DanielNoord enabled auto-merge (squash) March 7, 2023 20:32
@DanielNoord DanielNoord merged commit 9c4fbed into pylint-dev:main Mar 7, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-to-astroid-2.15.0 branch March 7, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants