[__implements__] Remove everything related to the rejected PEP245 #8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Breaking changes for 3.0 🦤
Maintenance
DanielNoord
reviewed
Mar 8, 2023
|
For |
|
I've done the cleanup, I'm going to push :) |
Pierre-Sassoulas
commented
Mar 8, 2023
Pierre-Sassoulas
commented
Mar 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8404 +/- ##
==========================================
+ Coverage 95.63% 95.66% +0.02%
==========================================
Files 176 176
Lines 18612 18531 -81
==========================================
- Hits 17799 17727 -72
+ Misses 813 804 -9
|
DudeNr33
previously approved these changes
Mar 8, 2023
There was a problem hiding this comment.
There are a few more places in pyreverse that can be cleaned up now, but the important stuff is included and tests adapted, thanks for that!
From the first quick look the following things can be removed as well:
DiagramWriter.write_classes--> everything related to implementation linksprinter.py:NodeType.INTERFACEandEdgeType.IMPLEMENTS, and for the concretePrinterclasses the places where those are used
As said I can take a closer look tomorrow and create a follow up PR. Especially the NodeType.INTERFACE is something that as far as I know did not even work as intended, and I would have to take a closer look at it as well.
Pierre-Sassoulas
dismissed stale reviews from DudeNr33 and DanielNoord
via
d329c2d
DanielNoord
previously approved these changes
Mar 8, 2023
for more information, see https://pre-commit.ci
DanielNoord
approved these changes
Mar 8, 2023
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on django:
Effect on music21:
The following messages are no longer emitted:
Effect on pandas:
The following messages are no longer emitted:
This comment was generated for commit 1c93e22 |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 9, 2023
Merged
Merged
toofar
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Oct 11, 2023
Changelog: https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html#summary-release-highlights remove `__implements__`: That attribute is apparently from a rejected PEP. They say to inherit from BaseChecker, which we are already doing. pylint-dev/pylint#8404 check_messages -> only_required_for_messages: Seems straightforward instructions. I haven't actually tested it. pylint-dev/pylint#8409 remove emptystring extension: Looks like this has been replaced by https://pylint.readthedocs.io/en/stable/user_guide/messages/convention/use-implicit-booleaness-not-comparison-to-string.html Which is disabled by default but we have `enable=ALL`, so I guess that means we indeed have it enabled. And update changelog URLs.
ivica-prose
added a commit
to prosehair/pylint_super_not_called_plugin
that referenced
this pull request
Oct 25, 2023
Pylint removed support for this in this PR pylint-dev/pylint#8404
ivica-prose
added a commit
to prosehair/pylint_super_not_called_plugin
that referenced
this pull request
Oct 26, 2023
Pylint removed support for this in this PR pylint-dev/pylint#8404
karlch
added a commit
to karlch/vimiv-qt
that referenced
this pull request
Nov 27, 2023
Was removed in pylint-dev/pylint#8404.
karlch
added a commit
to karlch/vimiv-qt
that referenced
this pull request
Nov 27, 2023
* Bump pylint from 2.17.5 to 3.0.2 in /misc/requirements Bumps [pylint](https://github.com/pylint-dev/pylint) from 2.17.5 to 3.0.2. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v2.17.5...v3.0.2) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Pylint checkers: remove __implements__ Was removed in pylint-dev/pylint#8404. * Pylint: Other fixes for pylint v3.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: karlch <karlch@protonmail.com>
caarmen
added a commit
to caarmen/pylint-json2checkstyle
that referenced
this pull request
Jan 20, 2024
Remove the `__implements__ = IReporter` to avoid issue #5. This was removed in pylint in pylint-dev/pylint#8404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Everything related to the
__implements__construct was removed. It was based on PEP245that was proposed in 2001 and rejected in 2006. It includes everything in
pylint.interfacesCheckershould only inheritBaseCheckeror any of the other checker types frompylint.checkers.Reportershould only inheritBaseReporter.The capability from pyreverse to take it into account when generating diagrams was also removed.