Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyreverse: remove remaining code parts related to __implements__ #8414

Merged

Conversation

DudeNr33
Copy link
Collaborator

@DudeNr33 DudeNr33 commented Mar 9, 2023

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

After removing the support for __implements__ with #8404 there are now some parts in the code that can be removed as well.

Refs #8404

@DudeNr33 DudeNr33 added pyreverse Related to pyreverse component Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry labels Mar 9, 2023
@DudeNr33 DudeNr33 added this to the 3.0.0b1 milestone Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #8414 (23637c4) into main (62889d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8414   +/-   ##
=======================================
  Coverage   95.68%   95.69%           
=======================================
  Files         175      175           
  Lines       18465    18454   -11     
=======================================
- Hits        17668    17659    -9     
+ Misses        797      795    -2     
Impacted Files Coverage Ξ”
pylint/pyreverse/dot_printer.py 85.22% <ΓΈ> (ΓΈ)
pylint/pyreverse/inspector.py 79.69% <ΓΈ> (ΓΈ)
pylint/pyreverse/printer.py 100.00% <ΓΈ> (ΓΈ)
pylint/pyreverse/utils.py 94.20% <ΓΈ> (-0.09%) ⬇️
pylint/pyreverse/vcg_printer.py 92.75% <ΓΈ> (ΓΈ)
pylint/pyreverse/writer.py 100.00% <ΓΈ> (+1.36%) ⬆️
pylint/pyreverse/diagrams.py 92.16% <100.00%> (+0.50%) ⬆️
pylint/pyreverse/mermaidjs_printer.py 98.18% <100.00%> (-0.04%) ⬇️
pylint/pyreverse/plantuml_printer.py 100.00% <100.00%> (ΓΈ)

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! I missed quite a lot !

@DudeNr33
Copy link
Collaborator Author

DudeNr33 commented Mar 9, 2023

We have two different milestones currently (3.0.0a6 and 3.0.0.b1). I saw that the other pyreverse PR (for the --show-stdlib option) was targeted for 3.0.0b1, so I set it here as well.
Do you want to release 3.0.0.a6 first before I merge?

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.0.0b1, 3.0.0a6 Mar 9, 2023
@Pierre-Sassoulas
Copy link
Member

3.0.0a6 is enacting the deprecations, there's some work to do still, but life goes on as usual, we're just going to release all enhancement / false negatives / other breaking changes as they come naturally. (Also this MR feel like enacting a deprecation.

@Pierre-Sassoulas Pierre-Sassoulas merged commit d04734d into pylint-dev:main Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 23637c4

@DudeNr33 DudeNr33 deleted the remove-pyreverse-interfaces branch March 11, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow pyreverse Related to pyreverse component Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants