Allow integers in TypeAlias names. #8488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks and updated documentation to reflect the rule behavior: Good2Name, GoodName2, _1BadName.
DanielNoord
reviewed
Mar 23, 2023
| | | ``typevars``. Note that ``TopName`` is allowed but | | | ||
| | | ``TTopName`` isn't. | | | ||
| | ``typealias`` | ``GoodName``, ``_GoodName``, ``IPAddressType``, | ``BadNameT``, ``badName``, ``TBadName``, ``TypeBadName`` | | ||
| | | 'GoodName2 and other PascalCase variants that don't | | |
There was a problem hiding this comment.
Suggested change
| | | 'GoodName2 and other PascalCase variants that don't | | | |
| | | ``GoodName2`` and other PascalCase variants that don't | | |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8488 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 174 174
Lines 18361 18361
=======================================
Hits 17612 17612
Misses 749 749
|
This comment has been minimized.
This comment has been minimized.
DanielNoord
reviewed
Mar 24, 2023
This comment has been minimized.
This comment has been minimized.
|
The documentation check seem to have failed for an unrelated issue: |
|
@DanielNoord I synced the branch with the latest main. I hoped this will get the last check to pass. |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
the
False Positive π¦
DanielNoord
approved these changes
Mar 28, 2023
DanielNoord
reviewed
Mar 28, 2023
| @@ -0,0 +1,5 @@ | |||
| ``invalid-name`` now allows for integers in ``typealias`` names: | |||
There was a problem hiding this comment.
Suggested change
| ``invalid-name`` now allows for integers in ``typealias`` names: | |
| ``invalid-name`` now allows for integers in ``typealias`` names: |
There was a problem hiding this comment.
I can't make commits to the branch so you'll need to do this yourself
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
(cherry picked from commit 43eb61e)
|
π€ Effect of this PR on checked open source code: π€ Effect on pandas:
This comment was generated for commit fa53728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Updated the pattern to allow integers and updated the documentation to reflect the rule behavior: Good2Name, GoodName2, _1BadName.
towncrier create 8485.false_positive
Closes #8485.