Fix bug with unclear function signature

[hmc-cs-mdrissi]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Fixes long open issue of getting tensorflow function signatures incorrect and producing false positives. Due to import/function definition of tensorflow functions sometimes infer finds multiple function definitions and picks wrong one. safe_infer does check that each function definition has same number of arguments, but it's possible the names/defaults vary.

Also added a few simple test cases. I manually tested with tf.concat and confirmed it fixed that false positive.

Closes #3613

[codecov]

Codecov Report

Merging #8668 (8a5e049) into main (81917bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8668   +/-   ##
=======================================
  Coverage   95.84%   95.85%           
=======================================
  Files         173      173           
  Lines       18492    18510   +18     
=======================================
+ Hits        17724    17742   +18     
  Misses        768      768           

Impacted Files	Coverage Δ
pylint/checkers/utils.py	95.76% <100.00%> (+0.07%)	⬆️

[Pierre-Sassoulas]

Looks great ! I think formatting the args make sense (it seems like it could be a performance hit a lot is done in this function). It does simplify the code and fix the issue though... Could you add a fragment for the changelog, please ?

[jacobtylerwalls]

I think formatting the args make sense (it seems like it could be a performance hit a lot is done in this function).

Agree. Let's try just comparing argnames() instead.

[jacobtylerwalls]

We're touching safe_infer() so let's not backport this.

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas:
The following messages are no longer emitted:

1. comparison-with-callable:
   Comparing against a callable, did you omit the parenthesis?
   https://github.com/pandas-dev/pandas/blob/0bc16da1e53e9a4d637cf81c770e6517da65a029/pandas/tests/arithmetic/test_datetime64.py#L699
2. comparison-with-callable:
   Comparing against a callable, did you omit the parenthesis?
   https://github.com/pandas-dev/pandas/blob/0bc16da1e53e9a4d637cf81c770e6517da65a029/pandas/tests/frame/test_arithmetic.py#L1096
3. comparison-with-callable:
   Comparing against a callable, did you omit the parenthesis?
   https://github.com/pandas-dev/pandas/blob/0bc16da1e53e9a4d637cf81c770e6517da65a029/pandas/tests/frame/test_arithmetic.py#L1097

This comment was generated for commit 8a5e049

[Pierre-Sassoulas]

The primer looks great !