Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add jobs for python 3.12-beta following its release #8718

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented May 26, 2023

Type of Changes

Type
✨ New feature

Description

3.12 is now in beta.
Closes #7741

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.12 labels May 26, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.0 milestone May 26, 2023
@github-actions

This comment has been minimized.

@Pierre-Sassoulas
Copy link
Member Author

Blocked by a new release of pip pypa/pip#11501

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Jun 3, 2023
@github-actions

This comment has been minimized.

@jacobtylerwalls
Copy link
Member

@Pierre-Sassoulas I read the linked issue, but there's no more work on the pip side, sounds like we just need to bump setuptools in pyproject.toml to >= 66.1.0?

@jacobtylerwalls jacobtylerwalls removed the Blocked 🚧 Blocked by a particular issue label Jun 7, 2023
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping a setuptools bump will work. Requested change to leave the primer alone, WDYT?

.github/workflows/primer_run_main.yaml Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added the Skip news 🔇 This change does not require a changelog entry label Jun 7, 2023
@Pierre-Sassoulas
Copy link
Member Author

Duh, should have started with astroid 🤦

@Pierre-Sassoulas
Copy link
Member Author

Blocked by pytest-dev/pytest#10894

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Jun 7, 2023
@jacobtylerwalls jacobtylerwalls added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jun 24, 2023
@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Jul 4, 2023

Blocked by #8822 (and an astroid 3.0.0a6)

@Pierre-Sassoulas
Copy link
Member Author

Blocked by #7767 and astroid 3.0.0a7 integration.

@jacobtylerwalls jacobtylerwalls removed Blocked 🚧 Blocked by a particular issue Needs astroid update Needs an astroid update (probably a release too) before being mergable labels Jul 10, 2023
@jacobtylerwalls jacobtylerwalls modified the milestones: 3.0.0, 3.0.0a7 Jul 14, 2023
"""A module that is accepted by Python but rejected by tokenize.

The problem is the trailing line continuation at the end of the line,
"""The problem is the trailing line continuation at the end of the line,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rejected in Python since python/cpython#13401

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #8718 (b7592e6) into main (4af294a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8718   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         173      173           
  Lines       18548    18552    +4     
=======================================
+ Hits        17785    17789    +4     
  Misses        763      763           
Impacted Files Coverage Δ
pylint/checkers/classes/class_checker.py 93.38% <ø> (ø)
pylint/checkers/base/name_checker/checker.py 98.61% <100.00%> (+0.01%) ⬆️
pylint/constants.py 100.00% <100.00%> (ø)
pylint/lint/pylinter.py 96.42% <100.00%> (ø)

@github-actions

This comment has been minimized.

@jacobtylerwalls jacobtylerwalls added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jul 15, 2023
DanielNoord
DanielNoord previously approved these changes Jul 15, 2023
@@ -35,6 +36,7 @@ requires-python = ">=3.8.0"
dependencies = [
"dill>=0.2;python_version<'3.11'",
"dill>=0.3.6;python_version>='3.11'",
"dill @ git+https://github.com/uqfoundation/dill.git@83ab36ce3e8cfcc0224aa99d5249a5e8f1c22590 ; python_version>='3.12'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is slowly becoming very ugly :(

@jacobtylerwalls jacobtylerwalls removed the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Jul 15, 2023
@github-actions
Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit b7592e6

@jacobtylerwalls jacobtylerwalls merged commit 3655f95 into pylint-dev:main Jul 15, 2023
45 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-python3.12-beta-in-ci branch July 15, 2023 15:52
pydsigner added a commit to pydsigner/anchovy that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.12 Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.12-dev to Github actions
3 participants