Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-2180: Treat line continuation at EOF as a SyntaxError #13401

Merged
merged 3 commits into from
May 18, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented May 18, 2019

This makes the parser consistent with the tokenize module (already the case
in pypy).

sample

x = 5\

before

$ python3 t.py
$ python3 -mtokenize t.py
t.py:2:0: error: EOF in multi-line statement

after

$ ./python t.py
  File "t.py", line 3
    x = 5\

         ^
SyntaxError: unexpected EOF while parsing
$ ./python -m tokenize t.py
t.py:2:0: error: EOF in multi-line statement

https://bugs.python.org/issue2180

@asottile asottile force-pushed the continuation_at_eof_bpo-2180 branch 3 times, most recently from 53334f7 to 3876813 Compare May 18, 2019 02:53
This makes the parser consistent with the tokenize module (already the case
in `pypy`).

sample
------

```python
x = 5\
```

before
------

```console
$ python3 t.py
$ python3 -mtokenize t.py
t.py:2:0: error: EOF in multi-line statement
```

after
-----

```console
$ ./python t.py
  File "t.py", line 3
    x = 5\

         ^
SyntaxError: unexpected EOF while parsing
$ ./python -m tokenize t.py
t.py:2:0: error: EOF in multi-line statement
```
@asottile asottile force-pushed the continuation_at_eof_bpo-2180 branch from 3876813 to 9437230 Compare May 18, 2019 02:55
@gpshead gpshead self-assigned this May 18, 2019
@gpshead gpshead added 🤖 automerge type-bug An unexpected behavior, bug, or error labels May 18, 2019
@miss-islington
Copy link
Contributor

@asottile: Status check is done, and it's a failure ❌ .

2 similar comments
@miss-islington
Copy link
Contributor

@asottile: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@asottile: Status check is done, and it's a failure ❌ .

Lib/test/test_eof.py Outdated Show resolved Hide resolved
@miss-islington
Copy link
Contributor

@asottile: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants