Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit decorator rollback session on raise 2xx and 3xx statuses #308

Closed
iRhonin opened this issue Mar 11, 2019 · 1 comment
Closed

Commit decorator rollback session on raise 2xx and 3xx statuses #308

iRhonin opened this issue Mar 11, 2019 · 1 comment
Assignees
@iRhonin
Labels
bug something isn't working
Milestone
v2

Comments

@iRhonin
Copy link
Contributor

iRhonin commented Mar 11, 2019 •
edited
Loading

Commit decorator rollback session on raise 2xx and 3xx statuses.

https://github.com/Carrene/restfulpy/blob/6313047f6c6cef2ed14dee82225f78bc6dff3b36/restfulpy/orm/__init__.py#L90-L93
@iRhonin iRhonin self-assigned this Mar 11, 2019
@iRhonin iRhonin added the bug something isn't working label Mar 11, 2019
@iRhonin iRhonin added this to the v2 milestone Mar 11, 2019
iRhonin added a commit that referenced this issue Mar 11, 2019
@iRhonin
Fixed commit decorator rollbaking the db session when HTTPSuccess and…
f024d08 
… HTTPRedirect raised, closes #308
@iRhonin iRhonin mentioned this issue Mar 11, 2019
Merged
pylover pushed a commit that referenced this issue Mar 12, 2019
@iRhonin @pylover
Fixed commit decorator rollbacked on 2xx and 3xx statuses (#304) (#307)
7291ac4 
* Fixed commit decorator rollbaking the db session when HTTPSuccess and HTTPRedirect raised, closes #308

* Added FIXME for unused verb= and url= in given

* Removed a blank line

* Removed verb= and url= from when

* Removed GET request

* Changed one() to one_or_none() to get better log

* Removed root url argument

* Removed unused criteria

* Removed assignments

* Changed one() to one_or_none()

* Renamed test model to Foo

* Coding style
@iRhonin
Copy link
Contributor Author

iRhonin commented Apr 8, 2019

Merged with release/2 branch in PR #307.

@iRhonin iRhonin closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iRhonin iRhonin

Labels
bug something isn't working
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@iRhonin