Add Complex Grassmann manifold #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvchev
reviewed
May 22, 2020
| class ComplexGrassmann(Manifold): | ||
| """ | ||
| Factory class for the Grassmann manifold. This is the manifold of p- | ||
| dimensional subspaces of n dimensional real vector space. Initiation |
There was a problem hiding this comment.
It should be complex vector space, no?
sylvchev
reviewed
May 22, 2020
| np_testing.assert_almost_equal(self.man.norm(X, self.man.log(X, Y)), | ||
| self.man.dist(X, Y)) | ||
|
|
||
| # def test_ehess2rhess(self): |
There was a problem hiding this comment.
You could remove this commented code if you don't plan to use it
sylvchev
reviewed
May 22, 2020
|
I corrected what was stated in the review. I have used this manifold for my personal needs but I have no plans to add an example at this time. |
|
Thanks for your contribution @antoinecollas and for looking into it @sylvchev 👍 From my side, this is ready to be merged; same remarks as for #113 apply. |
sylvchev
previously approved these changes
Jul 15, 2020
sweichwald
previously approved these changes
Jul 15, 2020
sweichwald
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have implemented the complex Grassmann manifold following the implementation of Manopt. I also implemented the corresponding unit tests.