Fix SMC regression and re-enable test_smc.py

pymc-devs · Jun 14, 2021 · ee122d0 · ee122d0
1 parent 8067f68
commit ee122d0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
@@ -35,7 +35,6 @@ jobs:
             --ignore=pymc3/tests/test_profile.py
             --ignore=pymc3/tests/test_random.py
             --ignore=pymc3/tests/test_shared.py
-            --ignore=pymc3/tests/test_smc.py
             --ignore=pymc3/tests/test_starting.py
             --ignore=pymc3/tests/test_step.py
             --ignore=pymc3/tests/test_tracetab.py

diff --git a/pymc3/smc/smc.py b/pymc3/smc/smc.py
@@ -87,7 +87,7 @@ def initialize_population(self):
         if self.start is None:
             init_rnd = sample_prior_predictive(
                 self.draws,
-                var_names=[v.name for v in self.model.unobserved_RVs],
+                var_names=[v.name for v in self.model.unobserved_value_vars],
                 model=self.model,
             )
         else:

diff --git a/pymc3/tests/test_smc.py b/pymc3/tests/test_smc.py
@@ -98,6 +98,7 @@ def test_start(self):
             trace = pm.sample_smc(500, start=start)
 
 
+@pytest.mark.xfail("SMC-ABC not refactored yet")
 class TestSMCABC(SeededTest):
     def setup_class(self):
         super().setup_class()