Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample_ppc uses a single chain only #2633

Closed
aplavin opened this issue Oct 16, 2017 · 4 comments · Fixed by #2725
Closed

sample_ppc uses a single chain only #2633

aplavin opened this issue Oct 16, 2017 · 4 comments · Fixed by #2725
Labels
beginner friendly bug

Comments

@aplavin
Copy link
Contributor

aplavin commented Oct 16, 2017

Judging both by the behavior of sample_ppc and its implementation code I see that it samples from a single chain of a MultiTrace. I guess that's because indexing into such trace returns samples from a single chain only and its len() is equal to the number of samples per chain. Not sure if that's on purpose, but it's certainly unexpected.

Versions and main components

  • PyMC3 Version: 3.1
  • Theano Version: 0.9.0
  • Python Version: 3.6
  • Operating system: Linux
  • How did you install PyMC3: conda
@junpenglao
Copy link
Member

Thanks for reporting @aplavin. @AustinRochford was working on a PR a while back #2460.

Any recent progress @AustinRochford?

@junpenglao
Copy link
Member

Oops found it, actually I think this is already resolved: #2567

@aplavin
Copy link
Contributor Author

aplavin commented Oct 16, 2017

@junpenglao well, it doesn't look resolved. I have e.g. the points iterator defined there, but sample_ppc doesn't use it anyway.

@junpenglao
Copy link
Member

Oh I see. PR welcome ;-)

@aplavin aplavin mentioned this issue Oct 16, 2017
Closed
@junpenglao junpenglao mentioned this issue Nov 21, 2017
Merged
junpenglao pushed a commit that referenced this issue Nov 21, 2017
Fix sample_ppc to use all chains (#2725)
66d21e1 
* Fix sample_ppc to use all chains

close #2633
Index to samples in all chains for sample_ppc and sample_ppc_w

* add release note
@junpenglao junpenglao mentioned this issue Jan 17, 2018
Closed
jordan-melendez pushed a commit to jordan-melendez/pymc3 that referenced this issue Feb 6, 2018
@jordan-melendez
Fix sample_ppc to use all chains (pymc-devs#2725)
c07405b 
* Fix sample_ppc to use all chains

close pymc-devs#2633
Index to samples in all chains for sample_ppc and sample_ppc_w

* add release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sample_ppc to use all chains
2 participants
@aplavin @junpenglao