Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the docker image? #3662

Closed
zscore opened this issue Oct 18, 2019 · 29 comments
Closed

Updating the docker image? #3662

zscore opened this issue Oct 18, 2019 · 29 comments

Comments

@zscore
Copy link
Contributor

zscore commented Oct 18, 2019

Hi everyone, I wanted to put pymc3 into a container and run it, and I noticed that the dockerhub hasn't been updated in a while. Could we add some new images for all the minor versions of pymc3? Also, it seems like it should be possible to configure the repo so that the github will push up these images automatically when a version is released https://docs.docker.com/docker-hub/builds/

@twiecki
Copy link
Member

twiecki commented Oct 19, 2019

Yeah, we should definitely set that up, I thought we already had that. Is this something you're interested in helping with (I could give you the required permissions to set it up)?

@zscore
Copy link
Contributor Author

zscore commented Oct 20, 2019

I'd love to do this 💃

@twiecki
Copy link
Member

twiecki commented Oct 21, 2019

Oh, I just realized we met at the trivago meetup, how's it going?

OK, I added you w write perms, let me know if there are other permissions required (probably at dockerhub?). Please note that once it's set up I will remove write privileges again.

@zscore
Copy link
Contributor Author

zscore commented Oct 21, 2019 via email

@twiecki
Copy link
Member

twiecki commented Oct 22, 2019

Yeah, not in Düsseldorf anymore, but I do miss it :).

OK, I need your email or docker ID.

@pymc-devs pymc-devs deleted a comment from zscore Oct 22, 2019
@zscore
Copy link
Contributor Author

zscore commented Oct 22, 2019

Okay here's the update: for some reason I could not select the pymc3 repository from the dropdown when I wanted to hook up the github repo to dockerhub, so instead I just forked it and hooked it up to build using my user. Hopefully the build goes through and will be available here https://hub.docker.com/r/pymc/pymc3. The long-term solution I think is to create a github user exclusively to attach to Dockerhub as described here https://docs.docker.com/docker-hub/builds/#service-users-for-team-autobuilds. @twiecki this is probably something that you or a trusted associate will have to set up since it involves a lot of permissions.

@zscore
Copy link
Contributor Author

zscore commented Oct 22, 2019

also it looks like the build failed on dockerhub, probably because the source files were not successfully added to the docker context. https://cloud.docker.com/u/pymc/repository/registry-1.docker.io/pymc/pymc3/builds/989703ba-751b-4429-a545-ae0af8f9a827

I can investigate this if people are interested

@twiecki
Copy link
Member

twiecki commented Oct 22, 2019

@zscore that'd be much appreciated!

@twiecki
Copy link
Member

twiecki commented Oct 22, 2019

@zscore I think I have added you to owners on docker hub, does it not work?

@zscore
Copy link
Contributor Author

zscore commented Oct 22, 2019

@twiecki, for some reason pymc3 does not show in the list of available repositories to build
image but I think we will have to make a dedicated account for the docker hub builds because docker hub authenticates to github with the user's permissions.

@twiecki
Copy link
Member

twiecki commented Oct 23, 2019

@zscore OK, is that something you can do?

@zscore
Copy link
Contributor Author

zscore commented Oct 23, 2019

actually yes I think I can do this. I'll check in with you once I've tried.

zscore added a commit to zscore/pymc3 that referenced this issue Dec 4, 2019
@zscore
Copy link
Contributor Author

zscore commented Dec 4, 2019

Sorry for the delay; I moved during November, and it took me until now to get to this issue again. I created a build rule within Dockerhub that allows us to create pymc3 docker images using the development environment defined in the scripts folder and installing the current pymc3 source as a package. You can find the successful build here: https://cloud.docker.com/u/pymc/repository/docker/pymc/pymc3/builds/63377995-341c-44e6-93b6-36196bc7d9e1

In the future, we might want to set up our Dockerfiles in a different repository so that we can create a different environment for end users and have a separate release cycle for Docker images independent from the pymc3 release cycle.

Please ignore the commit for #3662 as it is no longer relevant.

Pending your approval @twiecki, I will take the following actions

Next Steps

  1. Create autobuild rule for tagged versions on the pymc/pymc3 dockerhub.
  2. Remove test builds from build history and old build rule.
  3. Create machine user for pymc-devs so that it can integrate the pymc3 repo on github with Dockerhub for automated builds.
  4. Remove me from pymc-devs github group and as an admin on pymc/pymc3 on dockerhub.

@zscore
Copy link
Contributor Author

zscore commented Dec 4, 2019

If anyone wants to check out the new docker image, it's available via docker pull pymc/pymc3:latest2

@twiecki
Copy link
Member

twiecki commented Dec 4, 2019

@zscore Thanks, that all sounds good to me, feel free to proceed. We should also update the docs with some instructions.

@pymc-machine-user
Copy link

This is the pymc machine user, with the catchy name of pymc-machine-user. I can private message you credentials for this account so that you can transfer ownership of it over to the pymc team.

@pymc-machine-user
Copy link

Also, I deleted the old build so the new build is available at docker pull pymc/pymc3. We might have to reconfigure the build rules though when we switch over to the pymc-devs/pymc3 repo.

zscore added a commit to zscore/pymc3 that referenced this issue Dec 5, 2019
zscore added a commit to zscore/pymc3 that referenced this issue Dec 5, 2019
@zscore
Copy link
Contributor Author

zscore commented Dec 5, 2019

@twiecki here's a PR that adds a docker badge to the README and to the index.html. Is there anywhere else I should document the Dockerhub configuration?

@twiecki
Copy link
Member

twiecki commented Dec 5, 2019

I'm confused, where is the PR? Probably the badge is good enough for now.

@zscore
Copy link
Contributor Author

zscore commented Dec 6, 2019

here is the PR #3710

twiecki pushed a commit that referenced this issue Dec 6, 2019
* Adding dockerhub badge to readme #3662

* Adding dockerhub badge to sphinx index.html #3662
@zscore
Copy link
Contributor Author

zscore commented Dec 9, 2019

@twiecki whom should i message about transferring over control of the pymc-machiner-user?

@twiecki
Copy link
Member

twiecki commented Dec 9, 2019

@zscore can you / do you want to keep that?

@zscore
Copy link
Contributor Author

zscore commented Dec 10, 2019

Sure, but we will need to add this user to the pymc-devs group so that it has access to the repository.

@twiecki
Copy link
Member

twiecki commented Dec 10, 2019

OK, I added the machine user and removed your account from the pymc team group. Are we all set with this? New containers will be built automatically with every push to master / every new release?

@pymc-machine-user
Copy link

one last thing, for some reason only the pymc4_prototypes and the resources repos are visible for autobuilds in dockerhub. could you check if there's some way you can change the pymc3 settings so it's also visible there?
Screenshot 2019-12-10 at 18 05 03

@twiecki
Copy link
Member

twiecki commented Dec 10, 2019

Seems like it does require admin rights. In that case, can you hand over account credentials to me?

@zscore
Copy link
Contributor Author

zscore commented Dec 10, 2019 via email

@twiecki
Copy link
Member

twiecki commented Dec 10, 2019

<firstname.lastname>@gmail.com

@twiecki
Copy link
Member

twiecki commented Dec 14, 2019

Seems like everything is working, thanks so much for the help @zscore, this is a great contribution!

@twiecki twiecki closed this as completed Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants