-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the docker image? #3662
Comments
Yeah, we should definitely set that up, I thought we already had that. Is this something you're interested in helping with (I could give you the required permissions to set it up)? |
I'd love to do this 💃 |
Oh, I just realized we met at the trivago meetup, how's it going? OK, I added you w write perms, let me know if there are other permissions required (probably at dockerhub?). Please note that once it's set up I will remove write privileges again. |
Things are good, finally starting to feel like I'm integrating a bit here.
How are you? You're not in Düsseldorf anymore right?
I think getting into the `pymc` docker organization should be sufficient
for this task https://hub.docker.com/u/pymc
Thanks for the help!
…-Zane
On Mon, Oct 21, 2019 at 5:06 AM Thomas Wiecki ***@***.***> wrote:
Oh, I just realized we met at the trivago meetup, how's it going?
OK, I added you w write perms, let me know if there are other permissions
required (probably at dockerhub?). Please note that once it's set up I will
remove write privileges again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3662>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUVKPA7LLDWV3HYHCAB4LTQPUMEXANCNFSM4JCKEJ4A>
.
|
Yeah, not in Düsseldorf anymore, but I do miss it :). OK, I need your email or docker ID. |
Okay here's the update: for some reason I could not select the |
also it looks like the build failed on dockerhub, probably because the source files were not successfully added to the docker context. https://cloud.docker.com/u/pymc/repository/registry-1.docker.io/pymc/pymc3/builds/989703ba-751b-4429-a545-ae0af8f9a827 I can investigate this if people are interested |
@zscore that'd be much appreciated! |
@zscore I think I have added you to owners on docker hub, does it not work? |
@twiecki, for some reason pymc3 does not show in the list of available repositories to build |
@zscore OK, is that something you can do? |
actually yes I think I can do this. I'll check in with you once I've tried. |
Sorry for the delay; I moved during November, and it took me until now to get to this issue again. I created a build rule within Dockerhub that allows us to create pymc3 docker images using the development environment defined in the scripts folder and installing the current pymc3 source as a package. You can find the successful build here: https://cloud.docker.com/u/pymc/repository/docker/pymc/pymc3/builds/63377995-341c-44e6-93b6-36196bc7d9e1 In the future, we might want to set up our Dockerfiles in a different repository so that we can create a different environment for end users and have a separate release cycle for Docker images independent from the pymc3 release cycle. Please ignore the commit for #3662 as it is no longer relevant. Pending your approval @twiecki, I will take the following actions Next Steps
|
If anyone wants to check out the new docker image, it's available via |
@zscore Thanks, that all sounds good to me, feel free to proceed. We should also update the docs with some instructions. |
This is the pymc machine user, with the catchy name of pymc-machine-user. I can private message you credentials for this account so that you can transfer ownership of it over to the pymc team. |
Also, I deleted the old build so the new build is available at docker pull pymc/pymc3. We might have to reconfigure the build rules though when we switch over to the pymc-devs/pymc3 repo. |
@twiecki here's a PR that adds a docker badge to the README and to the index.html. Is there anywhere else I should document the Dockerhub configuration? |
I'm confused, where is the PR? Probably the badge is good enough for now. |
here is the PR #3710 |
@twiecki whom should i message about transferring over control of the pymc-machiner-user? |
@zscore can you / do you want to keep that? |
Sure, but we will need to add this user to the pymc-devs group so that it has access to the repository. |
OK, I added the machine user and removed your account from the pymc team group. Are we all set with this? New containers will be built automatically with every push to master / every new release? |
Seems like it does require admin rights. In that case, can you hand over account credentials to me? |
sure thing where can i send the credentials to?
…On Tue, Dec 10, 2019 at 6:30 PM Thomas Wiecki ***@***.***> wrote:
Seems like it does require admin rights. In that case, can you hand over
account credentials to me?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3662>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUVKPB3XTFEO7HUAFGQ6HLQX7G35ANCNFSM4JCKEJ4A>
.
|
<firstname.lastname>@gmail.com |
Seems like everything is working, thanks so much for the help @zscore, this is a great contribution! |
Hi everyone, I wanted to put pymc3 into a container and run it, and I noticed that the dockerhub hasn't been updated in a while. Could we add some new images for all the minor versions of pymc3? Also, it seems like it should be possible to configure the repo so that the github will push up these images automatically when a version is released https://docs.docker.com/docker-hub/builds/
The text was updated successfully, but these errors were encountered: