Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings for better rendering on website and numpydoc compliance #5459

Open
Tracked by #7053
OriolAbril opened this issue Feb 10, 2022 · 24 comments
Open
Tracked by #7053

Comments

@OriolAbril
Copy link
Member

OriolAbril commented Feb 10, 2022

Overview

We have to review and update all the docstrings of objects part of the public API (that is, that appear on the API reference section of the website). Why?

There are two main reasons:

  • Some functions are not documented correctly. i.e. pymc.Uniform didn't document that lower and upper bounds are optional and default to 0 and 1 respectively
  • Not following numpydoc results in non-ideal rendering. i.e. if there are no spaces around the colon that separates parameter name and type numpydoc+sphinx can't render it correctly and the type ends up being shown as bold text instead of being a link to the documentation of that object (which is particularly useful for functions taking or returning external objects such as ArviZ InferenceData or aesara TensorVariable).

Current view of the parameter section of pymc.Uniform

imatge

Before doing the changes described below

imatge

Details

A detailed tutorial on how to go about these updates is available at the PyMC-Data Umbrella sprint website (the page also has a video recorded by @reshamas showing an example PR).

How to choose what page to work on?

Look for pages that don't have hyperlinks in all their parameters. In case of doubt, don't hesitate to ask in this issue for pages to work on.

@ravichikkam
Copy link
Contributor

ravichikkam commented Feb 15, 2022

I am working on the docstrings for weibull distribution.

EDIT (by @OriolAbril ): I moved the updated list to the initial comment so its easier to find for new people getting to this issue

@jmloyola
Copy link
Contributor

Working on pm.Data.

@cuchoi
Copy link
Member

cuchoi commented Feb 18, 2022

Is this where the ConstantData and MutableData docs should appear? https://docs.pymc.io/en/v3/api/data.html. I can't find them.

Edit: There in v4 here https://docs.pymc.io/en/latest/api/data.html

@chritter
Copy link
Contributor

chritter commented Feb 18, 2022

Working on pymc.Exponential

@cuchoi
Copy link
Member

cuchoi commented Feb 18, 2022

Going to work on pymc.HyperGeometric

@sagartomar
Copy link
Contributor

Working on pymc.Normal

@lalitmusmade
Copy link
Contributor

Working on pymc.Flat

@GallowayJ
Copy link
Contributor

Working on pymc.GaussianRandomWalk

@areding
Copy link
Contributor

areding commented Feb 19, 2022

I'll start on pymc.Gamma

@areding
Copy link
Contributor

areding commented Feb 19, 2022

Starting pymc.InverseGamma.

@sagartomar
Copy link
Contributor

Starting with pymc.Beta

@bdatko
Copy link

bdatko commented Jul 9, 2022

@jlindbloom and I are working on Other utils

@pibieta
Copy link
Contributor

pibieta commented Jul 16, 2022

I am working on the class docstrings inside the multivariate module.

@vitaliset
Copy link
Contributor

Me and @pibieta are working on the rest of the classes docstrings inside the multivariate module.
#DataUmbrellaPyMCSprint
Cc: @reshamas

@daniel-saunders-phil
Copy link
Contributor

working on docstring for pm.simulator

@rowan-schaefer
Copy link
Contributor

I can take smc

@daniel-saunders-phil
Copy link
Contributor

I can take smc

maybe we could work together on it! I've been working with a little bit this week and have a number of ideas. Do you know a good technique to co-write a PR?

@rowan-schaefer
Copy link
Contributor

I'll message you!

@daniel-saunders-phil
Copy link
Contributor

I'll take pm.AR

@rowan-schaefer
Copy link
Contributor

Currently working on pymc.variational.inference!

@OriolAbril OriolAbril mentioned this issue Nov 8, 2022
3 tasks
@hyosubkim
Copy link
Contributor

I will work on pymc.DiscreteWeibull

@apalermo01
Copy link
Contributor

I'm getting pymc.model.core.Model

@HangenYuu
Copy link

HangenYuu commented Mar 22, 2024

I will work on pymc.step_methods.BinaryGibbsMetropolis at this link: https://www.pymc.io/projects/docs/en/stable/api/generated/pymc.step_methods.BinaryGibbsMetropolis.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests