Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indentation in record #1632

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Fixed indentation in record #1632

merged 1 commit into from
Jan 1, 2017

Conversation

fonnesbeck
Copy link
Member

Found this indentation issue in the SQLite backend; can add it to next RC if one is required, otherwise can wait for merge post-3.0.

@springcoil springcoil merged commit 4079f6e into master Jan 1, 2017
@springcoil springcoil deleted the sqlite_record_indent branch January 1, 2017 23:03
@springcoil
Copy link
Contributor

I think it's fine to merge this into the current release candidate as it's a useful bug fix but not a major change.

@kyleam
Copy link
Contributor

kyleam commented Jan 2, 2017

@fonnesbeck Was this in response to a bug you observed in the sqlite
output?

_execute_queue loops over self.varnames, so I don't think it was
intended to be called in the inner loop. varname from the loop is
just used to get the current length of the queue (i.e., it could be
any member of self.varnames). Stylistically, it would probably be
clearer to use self.varnames[0].

@fonnesbeck
Copy link
Member Author

@kyleam no, I noticed it while linting. That makes sense, though. I can revert and use the self.varnames[0] syntax you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants