Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid unbound local ref on exc before first sample #1713

Merged
merged 1 commit into from
Jan 26, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions pymc3/sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,15 @@ def _sample(draws, step=None, start=None, trace=None, chain=0, tune=None,
if progressbar:
sampling = tqdm(sampling, total=draws)
try:
strace = None
for strace in sampling:
pass
except KeyboardInterrupt:
strace.close()
return MultiTrace([strace]) # pylint: disable=undefined-loop-variable
result = [] if strace is None else [strace]
except KeyboardInterrupt as exc:
if strace is not None:
strace.close()
raise exc
return MultiTrace(result)


def iter_sample(draws, step, start=None, trace=None, chain=0, tune=None,
Expand Down