OPVI speedup #2759
Merged
OPVI speedup #2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job @ferrine, i can confirm speed up (around 25% increase, tested using advi and fullrank_advi) |
|
Relieved this is fixed. I think we should release 3.3 or 3.2.1 for this (and the few other changes). |
jordan-melendez
pushed a commit
to jordan-melendez/pymc3
that referenced
this pull request
Feb 6, 2018
* fix scan op redundancy * fix clear cache * Better solution for caching * Redundant usages of memoize * Clear cache function * clear cache * fix testing * fix unused import * fix imports * fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes speed issues with OPVI and also fixes memory leak with cache
CC @junpenglao @aseyboldt