remove deprecated code #2781
remove deprecated code #2781
Conversation
|
Are the are any NBs that depend on it? |
|
I'm not sure about this. I think it sets a bad precedent for cluttering up the project. Why not just deprecate and remove in the next release? I don't think its a big ask to have users switch to the new API, or if it is a legacy analysis, it can be tied to a previous version of PyMC3. |
Fair, so removing at all sounds nice too. It is deprecated for a long time already |
|
I think it's time... |
ferrine
changed the title
legacy subfolder
| @@ -27,6 +27,11 @@ | |||
| - Fixed `sample_ppc` and `sample_ppc_w` to iterate all chains(#2633, #2748) | |||
| - Add Bayesian R2 score (for GLMs) `stats.r2_score` (#2696) and test (#2729). | |||
| - SMC works with transformed variables (#2755) | |||
| - Speedup OPVI (#2759) | |||
There was a problem hiding this comment.
I think you should add a new PR for this, and put the below Deprecations into a new unreleased (making the deprecation the next release)
There was a problem hiding this comment.
But we have not yet released 3.3, only release candidate
There was a problem hiding this comment.
If its already been deprecated, we can remove it in 3.3
|
Can this be merged? I'd like to put it in 3.3. The failure is a timeout. |
* move deprecated code to `legacy` subfolder * add to release notes * add note for OPVI * fix imports * remove old advi
No description provided.