Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterization docs fix for precision/standard deviations. #2789

Merged
merged 8 commits into from
Jan 14, 2018
Merged

Parameterization docs fix for precision/standard deviations. #2789

merged 8 commits into from
Jan 14, 2018

Conversation

ericmjl
Copy link
Member

@ericmjl ericmjl commented Jan 12, 2018

fix #2788

@ericmjl ericmjl mentioned this pull request Jan 12, 2018
7 tasks
"tau only required if sd not specified."

Previously was "tau only required if tau not specified."
@ericmjl ericmjl changed the title Parameterization docs fix for Normal distribution. Parameterization docs fix for precision/standard deviations. Jan 13, 2018
x = pm.StudentT('x', nu=15, mu=0, sd=10)

with pm.Model():
x = pm.StudentT('x', nu=15, mu=0, sd=1/23)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be lam here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -347,9 +355,17 @@ class HalfNormal(PositiveContinuous):
Parameters
----------
sd : float
Standard deviation (sd > 0).
Standard deviation (sd > 0) .(only required if tau is not specified)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move . to the end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tau : float
Precision (tau > 0).
Precision (tau > 0). (only required if sd is not specified)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@junpenglao junpenglao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fonnesbeck fonnesbeck merged commit 5eefc14 into pymc-devs:master Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterization docs to fix.
4 participants